-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload Identity: allow passing roles to created service account #708
Merged
morgante
merged 4 commits into
terraform-google-modules:master
from
MeNsaaH:feat/add-roles-to-workload-identity
Oct 12, 2020
Merged
Workload Identity: allow passing roles to created service account #708
morgante
merged 4 commits into
terraform-google-modules:master
from
MeNsaaH:feat/add-roles-to-workload-identity
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeNsaaH
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
October 9, 2020 16:01
Thanks for the PR! 🚀 |
bharathkkb
requested changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
bharathkkb
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @morgante
Thanks for the contribution! |
marko7460
pushed a commit
to marko7460/terraform-google-kubernetes-engine
that referenced
this pull request
Oct 13, 2020
bharathkkb
added a commit
that referenced
this pull request
Oct 14, 2020
* fix: promoting release_channel, database_encryption, workload_identity_config, and enable_shielded_nodes from beta to GA * feat: allow passing roles to created Workload Identity service account (#708) * Moving autoscaling from beta to GA * Moving binary authorization from beta to GA Co-authored-by: Mmadu Manasseh <mmadumanasseh@gmail.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…e-modules#709) * fix: promoting release_channel, database_encryption, workload_identity_config, and enable_shielded_nodes from beta to GA * feat: allow passing roles to created Workload Identity service account (terraform-google-modules#708) * Moving autoscaling from beta to GA * Moving binary authorization from beta to GA Co-authored-by: Mmadu Manasseh <mmadumanasseh@gmail.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #694