Skip to content
This repository was archived by the owner on May 29, 2023. It is now read-only.

feat: add GCS DPEs to Yoshi Python team #497

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Feb 4, 2020

Add GCS DPEs @tritone, @jkwlui, @frankyn to Yoshi Python team.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2020
@frankyn frankyn changed the title Add GCS DPEs to Yoshi Python team feat: add GCS DPEs to Yoshi Python team Feb 4, 2020
users.json Outdated
"HemangChothani",
"helinwang",
"IlyaFaer",
"jesselovelace",
"jonathanlui",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be github username yes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. yep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao yes!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! thanks for the catch!

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #497   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           7      7           
  Lines        1596   1596           
=====================================
  Misses       1596   1596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9225e03...f869ec0. Read the comment docs.

@frankyn
Copy link
Contributor Author

frankyn commented Feb 4, 2020

I can't merge because I don't have the permission. @JustinBeckwith or @crwilcox if you can help merge that would be appreciated! Thank you for the fast review.

@JustinBeckwith JustinBeckwith merged commit 83d2d39 into googleapis:master Feb 4, 2020
@JustinBeckwith
Copy link
Contributor

Uh

Error adding franknatividad to googleapis/yoshi-python.
Not Found

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants