perf: improve streaming performance #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
skuruppu
approved these changes
Feb 23, 2021
harmon
reviewed
Feb 26, 2021
|
|
||
| def _merge_values(self, values): | ||
| """Merge values into rows. | ||
|
|
||
| :type values: list of :class:`~google.protobuf.struct_pb2.Value` | ||
| :param values: non-chunked values from partial result set. | ||
| """ | ||
| width = len(self.fields) | ||
| print(self.fields) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes performance issues that were introduced during the mirgration to v2 and optimizes several streaming methods.
From v2 onwards, the library uses
proto-plusto produce user friendly Python object to represent proto messages. Unfortunately, it significantly impacted the performance of streaming for cases with many columns as the library must unnecessarily parse the types many times. By reverting the streaming changes to use the raw protobuf messages, the streaming speed is greatly improved.Fixes #207, fixes #234