feat: expose boot disk type and size for CustomTrainingJob, CustomPythonPackageTrainingJob, and CustomContainerTrainingJob #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
morgandu
force-pushed
the
mor--expose-disk-spec-for-custom-training
branch
from
2b06a22 to
9684547
Compare
sasha-gitg
requested changes
Aug 11, 2021
There was a problem hiding this comment.
LGTM for training_jobs.
jobs.CustomJob.from_local_script should also be updated: https://github.com/googleapis/python-aiplatform/blob/master/google/cloud/aiplatform/jobs.py#L1050
…ningJob, CustomContainerTrainingJob
fix: typehint for command line arguments to be passed to the Python task fix: change _MachineSpec to _WorkerPoolSpec
morgandu
force-pushed
the
mor--expose-disk-spec-for-custom-training
branch
from
9684547 to
eb99bd0
Compare
vinnysenthil
approved these changes
Aug 12, 2021
sasha-gitg
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<b/193822723> 🦕
_MachineSpecto_WorkerPoolSpecboot_disk_typeandboot_disk_size_gbin_MachineSpecand_DistributedTrainingSpecboot_disk_typeandboot_disk_size_gbinrunwith default values ofCustomTrainingJob,CustomPythonPackageTrainingJob, andCustomContainerTrainingJobboot_disk_typeandboot_disk_size_gbin_CustomTrainingJob._prepare_and_validate_runboot_disk_typeandboot_disk_size_gbinCustomJob.from_local_scriptargsto be passed to the Python task