Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add AutoML vision, Custom training job, and generic prediction samples #300

Merged
merged 22 commits into from
May 12, 2021
Merged

feat: Add AutoML vision, Custom training job, and generic prediction samples #300

merged 22 commits into from
May 12, 2021

Conversation

andrewferlitsch
Copy link
Contributor

MBSDK samples + tests

@andrewferlitsch andrewferlitsch requested review from dizcology and a team as code owners April 8, 2021 19:17
@andrewferlitsch andrewferlitsch requested a review from engelke April 8, 2021 19:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2021
@snippet-bot
Copy link

snippet-bot bot commented Apr 8, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@vinnysenthil vinnysenthil requested review from vinnysenthil and removed request for engelke April 8, 2021 19:22
@vinnysenthil vinnysenthil changed the title Andy dev feat: Add AutoML vision, Custom training job, and generic prediction samples Apr 8, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 9, 2021
@google-cla
Copy link

google-cla bot commented Apr 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 13, 2021
@vinnysenthil vinnysenthil requested a review from sasha-gitg April 13, 2021 01:27
@vinnysenthil
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 13, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 13, 2021
sasha-gitg
sasha-gitg approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments. Also, I notice some samples use asynchronous work flow while others don't. Is that intended?

samples/model-builder/custom_training_job_sample.py Outdated Show resolved Hide resolved
samples/model-builder/custom_training_job_sample.py Outdated Show resolved Hide resolved
samples/model-builder/custom_training_job_sample.py Show resolved Hide resolved
samples/model-builder/custom_training_job_sample_test.py Outdated Show resolved Hide resolved
@vinnysenthil vinnysenthil changed the base branch from dev to master May 3, 2021 22:34
@vinnysenthil vinnysenthil requested a review from a team as a code owner May 3, 2021 22:34
@vinnysenthil vinnysenthil added the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
@vinnysenthil vinnysenthil merged commit cc1a708 into master May 12, 2021
@vinnysenthil vinnysenthil deleted the andy-dev branch May 12, 2021 21:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology left review comments

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@vinnysenthil vinnysenthil vinnysenthil approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewferlitsch @vinnysenthil @dizcology @sasha-gitg