This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
feat(samples): add sample of configuring alternate apiEndpoint #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@bradmiro am I to understand we're not to land this yet? |
|
That's my understanding
…On Thu, Oct 31, 2019, 2:44 PM Benjamin E. Coe ***@***.***> wrote:
@bradmiro <https://github.com/bradmiro> am I to understand we're not to
land this yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#473?email_source=notifications&email_token=AFOVNV6EDIZTCA7TP5KGSILQRMRQZA5CNFSM4JGMQHU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECY3DFQ#issuecomment-548516246>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFOVNV4QQSTFGVFO7HDIF43QRMRQZANCNFSM4JGMQHUQ>
.
|
JustinBeckwith
added
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 81 81
Lines 1519 1519
=======================================
Hits 1027 1027
Misses 492 492Continue to review full report at Codecov.
|
|
@bradmiro I think we're able to move forwards with this again this week? |
|
I still haven't heard anything on my end, but it's possible you have information that I don't. Update: this is on hold until further notice |
JustinBeckwith
changed the title
|
@bcoe We're good to move forward with this |
bradmiro
changed the title
bradmiro
removed
do not merge
bcoe
changed the title
bcoe
approved these changes
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To store reverted changes with setEndpoint samples