Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: do not modify options object, use defaultScopes #399

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

alexander-fenster
Copy link
Contributor

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@alexander-fenster alexander-fenster requested a review from a team as a code owner November 6, 2020 22:27
@product-auto-label product-auto-label bot added the api: cloudkms Issues related to the googleapis/nodejs-kms API. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #399 (0586a31) into master (43b555d) will increase coverage by 0.01%.
The diff coverage is 98.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   97.93%   97.95%   +0.01%     
==========================================
  Files           5        5              
  Lines        3829     3910      +81     
  Branches      128      126       -2     
==========================================
+ Hits         3750     3830      +80     
- Misses         78       79       +1     
  Partials        1        1              
Impacted Files Coverage Δ
src/v1/key_management_service_client.ts 98.50% <98.78%> (+<0.01%) ⬆️
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b555d...474550b. Read the comment docs.

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has conflicts that you need to resolve before merge-on-green can automerge

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has conflicts that you need to resolve before merge-on-green can automerge

@gcf-merge-on-green gcf-merge-on-green bot merged commit 288b417 into master Nov 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 7, 2020
@alexander-fenster alexander-fenster deleted the ggt-1.2.1 branch November 7, 2020 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudkms Issues related to the googleapis/nodejs-kms API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants