Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ErrorMessage from index.ts? #584

Closed
cakoose opened this issue Jun 20, 2021 · 1 comment · Fixed by #604
Closed

Export ErrorMessage from index.ts? #584

cakoose opened this issue Jun 20, 2021 · 1 comment · Fixed by #604
Assignees
@minherz
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@cakoose
Copy link

cakoose commented Jun 20, 2021

I'm using the "manual error reporting" flow. What's a little strange is that the ErrorMessage type (returned from ErrorReporting.event() isn't exported from the top-level of the package.

I end up having to import it from a weird spot, e.g.:

import {ErrorMessage} from '@google-cloud/error-reporting/build/src/classes/error-message';

Is there a better way to import this type?
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Jun 20, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 21, 2021
@freelerobot freelerobot added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jun 23, 2021
@freelerobot
Copy link
Contributor

Great point - we should explicitly export it.

@simonz130 simonz130 added the type: question Request for information or clarification. Not an issue. label Jun 23, 2021
@freelerobot freelerobot assigned simonz130 and unassigned freelerobot Jun 29, 2021
@keenan-devrel keenan-devrel assigned minherz and unassigned simonz130 Sep 30, 2021
minherz added a commit that referenced this issue Oct 1, 2021
@minherz
fix: export ErrorMessage as part of the package
906f0ad 
Fixes #584
@minherz minherz mentioned this issue Oct 1, 2021
Merged
minherz added a commit that referenced this issue Oct 4, 2021
@minherz
fix: export ErrorMessage as part of the package (#604)
eeb0218 
Fixes #584
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 4, 2021
@release-please
chore: release 2.0.4 (#605)
88ffebb 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.0.4](https://www.github.com/googleapis/nodejs-error-reporting/compare/v2.0.3...v2.0.4) (2021-10-04)


### Bug Fixes

* export ErrorMessage as part of the package ([#604](https://www.github.com/googleapis/nodejs-error-reporting/issues/604)) ([eeb0218](https://www.github.com/googleapis/nodejs-error-reporting/commit/eeb02180691260960438b1fbb42425843aa2d677)), closes [#584](https://www.github.com/googleapis/nodejs-error-reporting/issues/584)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: export ErrorMessage as part of the package googleapis/nodejs-error-reporting
5 participants
@cakoose @minherz @simonz130 @yoshi-automation @freelerobot