Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat!: add policy tag manager, move resource classes v1beta1 #32

Merged
merged 2 commits into from
Nov 20, 2019
Merged

feat!: add policy tag manager, move resource classes v1beta1 #32

merged 2 commits into from
Nov 20, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 14, 2019 •
edited
Loading

BREAKING CHANGE: resource classes such as CreateEntryGroupRequest have moved to the com.google.cloud.datacatalog.v1beta1 package.

Fixes internal issue 138402054

Fixes https://github.com/googleapis/java-datacatalog/issues/33

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
@tswast tswast changed the title feat(bigquery)!: add policy tag manager, move resource classes v1beta1 feat!: add policy tag manager, move resource classes v1beta1 Nov 14, 2019
@tswast tswast force-pushed the b138402054-policy-tag-manager branch from 0b5baa9 to d0eda33 Compare November 14, 2019 20:35
@tswast
Copy link
Contributor Author

tswast commented Nov 14, 2019

Failing checkstyle.

[INFO] --- maven-checkstyle-plugin:3.1.0:check (checkstyle) @ grpc-google-cloud-datacatalog-v1beta1 ---
[INFO] Starting audit...
[ERROR] /tmpfs/src/github/java-datacatalog/grpc-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogGrpc.java:1: Line does not match expected header line of '^/\*$'. [RegexpHeader]
[ERROR] /tmpfs/src/github/java-datacatalog/grpc-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/PolicyTagManagerGrpc.java:1: Line does not match expected header line of '^/\*$'. [RegexpHeader]
[ERROR] /tmpfs/src/github/java-datacatalog/grpc-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/PolicyTagManagerSerializationGrpc.java:1: Line does not match expected header line of '^/\*$'. [RegexpHeader]
Audit done.
[INFO] ------------------------------------------------------------------------

@tswast
Copy link
Contributor Author

tswast commented Nov 19, 2019

Added license headers in 09a3026

@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #32 into master will decrease coverage by 33.81%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #32       +/-   ##
=============================================
- Coverage     83.25%   49.43%   -33.82%     
  Complexity      153      153               
=============================================
  Files             6       18       +12     
  Lines          1206     2031      +825     
  Branches          3        5        +2     
=============================================
  Hits           1004     1004               
- Misses          199     1024      +825     
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...acatalog/v1beta1/stub/DataCatalogStubSettings.java 84.12% <ø> (ø) 34 <0> (ø) ⬇️
...cloud/datacatalog/v1beta1/DataCatalogSettings.java 9.33% <ø> (ø) 2 <0> (ø) ⬇️
...loud/datacatalog/v1beta1/stub/DataCatalogStub.java 3.7% <ø> (ø) 1 <0> (ø) ⬇️
...e/cloud/datacatalog/v1beta1/DataCatalogClient.java 84.32% <ø> (ø) 83 <0> (ø) ⬇️
.../datacatalog/v1beta1/stub/GrpcDataCatalogStub.java 97.85% <ø> (ø) 30 <0> (ø) ⬇️
...v1beta1/PolicyTagManagerSerializationSettings.java 0% <0%> (ø) 0 <0> (?)
...a1/stub/GrpcPolicyTagManagerSerializationStub.java 0% <0%> (ø) 0 <0> (?)
...1beta1/stub/PolicyTagManagerSerializationStub.java 0% <0%> (ø) 0 <0> (?)
...catalog/v1beta1/stub/GrpcPolicyTagManagerStub.java 0% <0%> (ø) 0 <0> (?)
...ud/datacatalog/v1beta1/PolicyTagManagerClient.java 0% <0%> (ø) 0 <0> (?)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906723b...35cbc02. Read the comment docs.

@tswast
Copy link
Contributor Author

tswast commented Nov 19, 2019 

[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 3 of 'public com.google.cloud.datacatalog.Entry createEntry(java.lang.String, java.lang.String, com.google.cloud.datacatalog.Entry)' has changed its type to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry createEntry(java.lang.String, java.lang.String, com.google.cloud.datacatalog.Entry)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Entry createEntry(com.google.cloud.datacatalog.CreateEntryRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.CreateEntryRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry createEntry(com.google.cloud.datacatalog.CreateEntryRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 3 of 'public com.google.cloud.datacatalog.EntryGroup createEntryGroup(java.lang.String, java.lang.String, com.google.cloud.datacatalog.EntryGroup)' has changed its type to com.google.cloud.datacatalog.v1beta1.EntryGroup
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.EntryGroup createEntryGroup(java.lang.String, java.lang.String, com.google.cloud.datacatalog.EntryGroup)' has been changed to com.google.cloud.datacatalog.v1beta1.EntryGroup
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.EntryGroup createEntryGroup(com.google.cloud.datacatalog.CreateEntryGroupRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.CreateEntryGroupRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.EntryGroup createEntryGroup(com.google.cloud.datacatalog.CreateEntryGroupRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.EntryGroup
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 2 of 'public com.google.cloud.datacatalog.Tag createTag(java.lang.String, com.google.cloud.datacatalog.Tag)' has changed its type to com.google.cloud.datacatalog.v1beta1.Tag
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Tag createTag(java.lang.String, com.google.cloud.datacatalog.Tag)' has been changed to com.google.cloud.datacatalog.v1beta1.Tag
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Tag createTag(com.google.cloud.datacatalog.CreateTagRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.CreateTagRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Tag createTag(com.google.cloud.datacatalog.CreateTagRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.Tag
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 3 of 'public com.google.cloud.datacatalog.TagTemplate createTagTemplate(java.lang.String, java.lang.String, com.google.cloud.datacatalog.TagTemplate)' has changed its type to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplate createTagTemplate(java.lang.String, java.lang.String, com.google.cloud.datacatalog.TagTemplate)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplate createTagTemplate(com.google.cloud.datacatalog.CreateTagTemplateRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.CreateTagTemplateRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplate createTagTemplate(com.google.cloud.datacatalog.CreateTagTemplateRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 3 of 'public com.google.cloud.datacatalog.TagTemplateField createTagTemplateField(java.lang.String, java.lang.String, com.google.cloud.datacatalog.TagTemplateField)' has changed its type to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplateField createTagTemplateField(java.lang.String, java.lang.String, com.google.cloud.datacatalog.TagTemplateField)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplateField createTagTemplateField(com.google.cloud.datacatalog.CreateTagTemplateFieldRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.CreateTagTemplateFieldRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplateField createTagTemplateField(com.google.cloud.datacatalog.CreateTagTemplateFieldRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public void deleteEntry(com.google.cloud.datacatalog.DeleteEntryRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.DeleteEntryRequest
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public void deleteEntryGroup(com.google.cloud.datacatalog.DeleteEntryGroupRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.DeleteEntryGroupRequest
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public void deleteTag(com.google.cloud.datacatalog.DeleteTagRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.DeleteTagRequest
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public void deleteTagTemplate(com.google.cloud.datacatalog.DeleteTagTemplateRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.DeleteTagTemplateRequest
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public void deleteTagTemplateField(com.google.cloud.datacatalog.DeleteTagTemplateFieldRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.DeleteTagTemplateFieldRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry getEntry(java.lang.String)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Entry getEntry(com.google.cloud.datacatalog.GetEntryRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.GetEntryRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry getEntry(com.google.cloud.datacatalog.GetEntryRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.EntryGroup getEntryGroup(java.lang.String, com.google.protobuf.FieldMask)' has been changed to com.google.cloud.datacatalog.v1beta1.EntryGroup
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.EntryGroup getEntryGroup(com.google.cloud.datacatalog.GetEntryGroupRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.GetEntryGroupRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.EntryGroup getEntryGroup(com.google.cloud.datacatalog.GetEntryGroupRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.EntryGroup
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplate getTagTemplate(java.lang.String)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplate getTagTemplate(com.google.cloud.datacatalog.GetTagTemplateRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.GetTagTemplateRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplate getTagTemplate(com.google.cloud.datacatalog.GetTagTemplateRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.v1beta1.DataCatalogClient$ListTagsPagedResponse listTags(com.google.cloud.datacatalog.ListTagsRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.ListTagsRequest
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Entry lookupEntry(com.google.cloud.datacatalog.LookupEntryRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.LookupEntryRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry lookupEntry(com.google.cloud.datacatalog.LookupEntryRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplateField renameTagTemplateField(java.lang.String, java.lang.String)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplateField renameTagTemplateField(com.google.cloud.datacatalog.RenameTagTemplateFieldRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.RenameTagTemplateFieldRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplateField renameTagTemplateField(com.google.cloud.datacatalog.RenameTagTemplateFieldRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.v1beta1.DataCatalogClient$SearchCatalogPagedResponse searchCatalog(com.google.cloud.datacatalog.SearchCatalogRequest$Scope, java.lang.String, java.lang.String)' has changed its type to com.google.cloud.datacatalog.v1beta1.SearchCatalogRequest$Scope
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.v1beta1.DataCatalogClient$SearchCatalogPagedResponse searchCatalog(com.google.cloud.datacatalog.SearchCatalogRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.SearchCatalogRequest
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Entry updateEntry(com.google.cloud.datacatalog.Entry, com.google.protobuf.FieldMask)' has changed its type to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry updateEntry(com.google.cloud.datacatalog.Entry, com.google.protobuf.FieldMask)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Entry updateEntry(com.google.cloud.datacatalog.UpdateEntryRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.UpdateEntryRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Entry updateEntry(com.google.cloud.datacatalog.UpdateEntryRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.Entry
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Tag updateTag(com.google.cloud.datacatalog.Tag, com.google.protobuf.FieldMask)' has changed its type to com.google.cloud.datacatalog.v1beta1.Tag
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Tag updateTag(com.google.cloud.datacatalog.Tag, com.google.protobuf.FieldMask)' has been changed to com.google.cloud.datacatalog.v1beta1.Tag
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.Tag updateTag(com.google.cloud.datacatalog.UpdateTagRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.UpdateTagRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.Tag updateTag(com.google.cloud.datacatalog.UpdateTagRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.Tag
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplate updateTagTemplate(com.google.cloud.datacatalog.TagTemplate, com.google.protobuf.FieldMask)' has changed its type to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplate updateTagTemplate(com.google.cloud.datacatalog.TagTemplate, com.google.protobuf.FieldMask)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplate updateTagTemplate(com.google.cloud.datacatalog.UpdateTagTemplateRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.UpdateTagTemplateRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplate updateTagTemplate(com.google.cloud.datacatalog.UpdateTagTemplateRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplate
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 2 of 'public com.google.cloud.datacatalog.TagTemplateField updateTagTemplateField(java.lang.String, com.google.cloud.datacatalog.TagTemplateField, com.google.protobuf.FieldMask)' has changed its type to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplateField updateTagTemplateField(java.lang.String, com.google.cloud.datacatalog.TagTemplateField, com.google.protobuf.FieldMask)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Parameter 1 of 'public com.google.cloud.datacatalog.TagTemplateField updateTagTemplateField(com.google.cloud.datacatalog.UpdateTagTemplateFieldRequest)' has changed its type to com.google.cloud.datacatalog.v1beta1.UpdateTagTemplateFieldRequest
[ERROR] 7006: com.google.cloud.datacatalog.v1beta1.DataCatalogClient: Return type of method 'public com.google.cloud.datacatalog.TagTemplateField updateTagTemplateField(com.google.cloud.datacatalog.UpdateTagTemplateFieldRequest)' has been changed to com.google.cloud.datacatalog.v1beta1.TagTemplateField
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient$ListTagsPage: Parameter 2 of 'protected com.google.cloud.datacatalog.v1beta1.DataCatalogClient$ListTagsPage createPage(com.google.api.gax.rpc.PageContext, com.google.cloud.datacatalog.ListTagsResponse)' has changed its type to com.google.cloud.datacatalog.v1beta1.ListTagsResponse
[ERROR] 7005: com.google.cloud.datacatalog.v1beta1.DataCatalogClient$SearchCatalogPage: Parameter 2 of 'protected com.google.cloud.datacatalog.v1beta1.DataCatalogClient$SearchCatalogPage createPage(com.google.api.gax.rpc.PageContext, com.google.cloud.datacatalog.SearchCatalogResponse)' has changed its type to com.google.cloud.datacatalog.v1beta1.SearchCatalogResponse
[INFO] -----------------------------------

These test failures are expected. The package name is intentionally changing, as it was incorrect before.

@tswast
Copy link
Contributor Author

tswast commented Nov 19, 2019

@chingor13 Please take a look.

@tswast
feat!: add policy tag manager, move resource classes v1beta1
eea0b14 
BREAKING CHANGE: resource classes such as `CreateEntryGroupRequest` have moved to the `com.google.cloud.datacatalog.v1beta1` package.
@tswast tswast force-pushed the b138402054-policy-tag-manager branch from d02920a to eea0b14 Compare November 19, 2019 23:27
@chingor13 chingor13 merged commit 3c11307 into googleapis:master Nov 20, 2019
@tswast tswast deleted the b138402054-policy-tag-manager branch November 21, 2019 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesis failed for java-datacatalog
3 participants
@tswast @chingor13 @googlebot