Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-java: fix build #11586

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

tgregg
Copy link
Contributor

@tgregg tgregg commented Feb 10, 2024

Fixes build failure for ion-java: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63457

withAnnotationIteratorReuseEnabled was removed from IonReaderBuilder. Removing this will cause the build to succeed.

NullPointerException, ArrayIndexOutOfBoundsException, and AssertionError should not leak from the library; such leaks would be useful to find during fuzzing.

Copy link

google-cla bot commented Feb 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

tgregg is a new contributor to projects/ion-java. The PR must be approved by known contributors before it can be merged. The past contributors are: henryrneh

@tgregg tgregg force-pushed the ion-java-fix-build branch 2 times, most recently from 74cd848 to 4712f3c Compare February 13, 2024 19:35
@tgregg tgregg force-pushed the ion-java-fix-build branch from 4712f3c to 235848a Compare February 15, 2024 23:37
@tgregg
Copy link
Contributor Author

tgregg commented Feb 15, 2024

@henryrneh could you please review this to unblock the PR workflow?

@DavidKorczynski
Copy link
Collaborator

@henryrneh could you please review this to unblock the PR workflow?

The CI is running now

@henryrneh
Copy link
Contributor

Approved 👍

@DavidKorczynski DavidKorczynski merged commit cb6ca09 into google:master Feb 16, 2024
15 checks passed
@tgregg tgregg deleted the ion-java-fix-build branch February 16, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants