Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.0.1 and v8.0.0 are not compatibles #620

Closed
Kikobeats opened this issue Jul 13, 2020 · 1 comment · Fixed by #619
Closed

v8.0.1 and v8.0.0 are not compatibles #620

Kikobeats opened this issue Jul 13, 2020 · 1 comment · Fixed by #619
Labels
bug

Comments

@Kikobeats
Copy link

Describe the bug

The version 8.0.1 is broken in a way isn't possible to publish a new version using the same scopes than the previous version

Current behavior

npx standard-version@8.0.1 -a
npx: installed 239 in 8.493s
✔ bumping version in package.json from 0.0.15 to 0.0.16
✔ outputting changes to CHANGELOG.md
✔ committing package.json and CHANGELOG.md and all staged files
husky > pre-commit (node v12.18.2)
[STARTED] Preparing...
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for package.json
[STARTED] Running tasks for *.js
[STARTED] Running tasks for *.md
[SKIPPED] No staged files match *.js
[STARTED] finepack
[STARTED] standard-markdown
[SUCCESS] standard-markdown
[SUCCESS] Running tasks for *.md
[SUCCESS] finepack
[SUCCESS] Running tasks for package.json
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
[SUCCESS] Applying modifications...
[STARTED] Cleaning up...
[SUCCESS] Cleaning up...
husky > commit-msg (node v12.18.2)
⧗   input: "chore(release): 0.0.16"
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

husky > commit-msg hook failed (add --no-verify to bypass)

Command failed: git commit -m "chore(release): 0.0.16"
husky > pre-commit (node v12.18.2)
[STARTED] Preparing...
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for package.json
[STARTED] Running tasks for *.js
[STARTED] Running tasks for *.md
[SKIPPED] No staged files match *.js
[STARTED] finepack
[STARTED] standard-markdown
[SUCCESS] standard-markdown
[SUCCESS] Running tasks for *.md
[SUCCESS] finepack
[SUCCESS] Running tasks for package.json
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
[SUCCESS] Applying modifications...
[STARTED] Cleaning up...
[SUCCESS] Cleaning up...
husky > commit-msg (node v12.18.2)
⧗   input: "chore(release): 0.0.16"
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

husky > commit-msg hook failed (add --no-verify to bypass)

Expected behavior

~/Projects/microlink/recipes master
❯ npx standard-version@8.0.0 -a
npx: installed 265 in 8.6s
✔ bumping version in package.json from 0.0.15 to 0.0.16
✔ outputting changes to CHANGELOG.md
✔ committing package.json and CHANGELOG.md and all staged files
husky > pre-commit (node v12.18.2)
[STARTED] Preparing...
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for package.json
[STARTED] Running tasks for *.js
[STARTED] Running tasks for *.md
[SKIPPED] No staged files match *.js
[STARTED] finepack
[STARTED] standard-markdown
[SUCCESS] standard-markdown
[SUCCESS] Running tasks for *.md
[SUCCESS] finepack
[SUCCESS] Running tasks for package.json
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
[SUCCESS] Applying modifications...
[STARTED] Cleaning up...
[SUCCESS] Cleaning up...
husky > commit-msg (node v12.18.2)

✔ tagging release v0.0.16
ℹ Run `git push --follow-tags origin master && npm publish` to publish
@Kikobeats Kikobeats added the bug label Jul 13, 2020
@runnerway runnerway mentioned this issue Jul 13, 2020
Merged
jbottigliero pushed a commit that referenced this issue Jul 14, 2020
@runnerway
fix: Commit message and tag name is no longer enclosed in quotes. (#619)
ae032bf 
- Authored by @runnerway – runExecFile (`child_process.execFile`) does not need additional quotes/escaping.

Closes #621, #620
@jbottigliero
Copy link
Member

Hi, thanks for the report – there was a bug related to additional (unnecessary) escaping of commit messages in 8.0.1, 8.0.2 contains a fix for this and has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't enclose commit message and tag name in quotes runnerway/standard-version
2 participants
@jbottigliero @Kikobeats