fix: get invalid ASDF_DATA_DIR when exec asdf shims by non-shell #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asdf_data_dir
function initsASDF_DATA_DIR
withHOME
when value is empty.HOME
may replace to empty string when asdf shims called by non-shell program.this makes invalid value of
ASDF_DATA_DIR
.the PR fixes this issue by use
asdf_dir
function instead of call environment variable.Other Information
I faced this issue when using
hugo
which installed by nklmilojevic/asdf-hugo and nodejs which installed by asdf-vm/asdf-nodejs like this:I looked into it by edit
$ASDF_DIR/bin/asdf
shebang as#!/usr/bin/env -S bash -x
.log: https://gist.github.com/knokmki612/41b4dd92580c8c893e834c83c946114e#file-asdf-hugo-server-log
My hugo site using PostCSS integration and hugo call
npx
(in my environment, this places as asdf shims) when build the site by this code. it seems no using sub shell and directly execnpx
. this will drop environment variables.Environments
.tool-versions: