Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usdAbc] Fix conversion of UsdGeomMesh subd interpolation options #1246

Merged
merged 2 commits into from
Jun 30, 2020
Merged

[usdAbc] Fix conversion of UsdGeomMesh subd interpolation options #1246

merged 2 commits into from
Jun 30, 2020

Conversation

barfowl
Copy link
Contributor

@barfowl barfowl commented Jun 16, 2020

Description of Change(s)

These changes correct errors in the conversion of mesh subdivision interpolation options between UsdGeomMesh and AbcGeom's ISubD and OSubD schemas:

  • the Abc reader was modified to use the correct name for Alembic's face-varying interpolation property (".faceVaryingInterpolateBoundary").
  • the Abc writer was modified to include two missing legal values values when converting faceVaryingLinearInterpolation, and to write the correct default value for interpolateBoundary.
  • the existing test for subdivision conversion between USD and Abc was updated to compare boundary and face-varying interpolation values after round trip conversion.

Fixes Issue(s)

  • conversion of faceVaryingLinearInterpolation from Abc ignores original values and results in the USD default.
  • conversion of faceVaryingLinearInterpolation to Abc generates errors for two legal USD values.
  • conversion of interpolateBoundary to Abc does not write the correct value for the USD default.

@barfowl
Fixed Abc translation issues with subd interpolation options:
8bdf8fa 
    - fixed reader to use the correct Alembic fvar-interpolation property name
    - fixed writer to handle all 6 legitimate USD cases for fvar-interpolation
    - fixed writer to assign corresponding Abc value for USD defaults
@barfowl
Updated usdAbc conversion test for subdivision meshes:
019b046 
    - assigned non-default values for interpolation options of test shape
    - tested scheme and interpolation options after round trip conversion
@barfowl
Copy link
Contributor Author

barfowl commented Jun 17, 2020

According to Azure the macOS job completed successfully after 34m. After over 4hrs now of "In progress ..." the confirmation of that success back to GitHub appears to be hanging.

@jtran56
Copy link

jtran56 commented Jun 23, 2020

Filed as internal issue #USD-6167.

@pixar-oss pixar-oss merged commit 06c7de1 into PixarAnimationStudios:dev Jun 30, 2020
@barfowl barfowl deleted the mesh_subd_options_to_abc branch July 7, 2020 21:06
@hughes123b

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barfowl @jtran56 @hughes123b @sunyab @c64kernal @pixar-oss