Make git panel entries clickable #22329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/git_ui/src/git_panel.rs
cla-bot
bot
added
the
cla-signed
This comment has been minimized.
This comment has been minimized.
CharlesChen0823
pushed a commit
to CharlesChen0823/zed
that referenced
this pull request
Dec 24, 2024
Makes a first pass over git panel UI, making it more interactive.  * every item can be selected, the selection is shown in the panel * every item can be clicked, which changes the selection and creates/focuses the editor with a project changes multi buffer * the editor is scrolled so that the clicked item is in the center * it's possible to nagivate up and down the panel, selecting next/previous items in it, triggering the editor scroll Known issues: * entries are updated oddly sometimes (should become better after DiffMap improvements land?) * only unstaged diffs are shown currently (entry status storage should help with this) * no deleted files are displayed (the underlying work is done by others now) * added files have no diff hunks shown (DiffMap will have it?) * performance story has not improved (again, DiffMap and status storage should help with this) Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a first pass over git panel UI, making it more interactive.
Known issues:
Release Notes: