Skip to content

Commit

Permalink
remove expose annotations from quickstarts and add bindable: false
Browse files Browse the repository at this point in the history
  • Loading branch information
Jim Minter committed Nov 7, 2017
1 parent 96e651f commit b84f207
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
8 changes: 3 additions & 5 deletions openshift/templates/nodejs-mongodb-persistent.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"openshift.io/long-description": "This template defines resources needed to develop a NodeJS application, including a build configuration, application deployment configuration, and database deployment configuration.",
"openshift.io/provider-display-name": "Red Hat, Inc.",
"openshift.io/documentation-url": "https://github.com/openshift/nodejs-ex",
"openshift.io/support-url": "https://access.redhat.com"
"openshift.io/support-url": "https://access.redhat.com",
"template.openshift.io/bindable": "false"
}
},
"message": "The following service(s) have been created in your project: ${NAME}, ${DATABASE_SERVICE_NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/openshift/nodejs-ex/blob/master/README.md.",
Expand Down Expand Up @@ -58,10 +59,7 @@
"kind": "Route",
"apiVersion": "v1",
"metadata": {
"name": "${NAME}",
"annotations": {
"template.openshift.io/expose-uri": "http://{.spec.host}{.spec.path}"
}
"name": "${NAME}"
},
"spec": {
"host": "${APPLICATION_DOMAIN}",
Expand Down
8 changes: 3 additions & 5 deletions openshift/templates/nodejs-mongodb.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"openshift.io/long-description": "This template defines resources needed to develop a NodeJS application, including a build configuration, application deployment configuration, and database deployment configuration. The database is stored in non-persistent storage, so this configuration should be used for experimental purposes only.",
"openshift.io/provider-display-name": "Red Hat, Inc.",
"openshift.io/documentation-url": "https://github.com/openshift/nodejs-ex",
"openshift.io/support-url": "https://access.redhat.com"
"openshift.io/support-url": "https://access.redhat.com",
"template.openshift.io/bindable": "false"
}
},
"message": "The following service(s) have been created in your project: ${NAME}, ${DATABASE_SERVICE_NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/openshift/nodejs-ex/blob/master/README.md.",
Expand Down Expand Up @@ -58,10 +59,7 @@
"kind": "Route",
"apiVersion": "v1",
"metadata": {
"name": "${NAME}",
"annotations": {
"template.openshift.io/expose-uri": "http://{.spec.host}{.spec.path}"
}
"name": "${NAME}"
},
"spec": {
"host": "${APPLICATION_DOMAIN}",
Expand Down
8 changes: 3 additions & 5 deletions openshift/templates/nodejs.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"openshift.io/long-description": "This template defines resources needed to develop a NodeJS application, including a build configuration and application deployment configuration. It does not include a database.",
"openshift.io/provider-display-name": "Red Hat, Inc.",
"openshift.io/documentation-url": "https://github.com/openshift/nodejs-ex",
"openshift.io/support-url": "https://access.redhat.com"
"openshift.io/support-url": "https://access.redhat.com",
"template.openshift.io/bindable": "false"
}
},
"message": "The following service(s) have been created in your project: ${NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/openshift/nodejs-ex/blob/master/README.md.",
Expand Down Expand Up @@ -45,10 +46,7 @@
"kind": "Route",
"apiVersion": "v1",
"metadata": {
"name": "${NAME}",
"annotations": {
"template.openshift.io/expose-uri": "http://{.spec.host}{.spec.path}"
}
"name": "${NAME}"
},
"spec": {
"host": "${APPLICATION_DOMAIN}",
Expand Down

0 comments on commit b84f207

Please sign in to comment.