Add support for exclusion constraints in create_table operation
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
commented
Jan 24, 2025
9 tasks
.github/workflows/build.yml
Outdated
| @@ -220,6 +220,7 @@ jobs: | |||
| if [ "$PGROLL_SCHEMA" != "public" ]; then | |||
| psql -h $POSTGRES_HOST -p $POSTGRES_PORT -U postgres -c "CREATE SCHEMA $PGROLL_SCHEMA;" | |||
| fi | |||
| psql -h $POSTGRES_HOST -p $POSTGRES_PORT -U postgres -c "CREATE EXTENSION IF NOT EXISTS btree_gist SCHEMA $PGROLL_SCHEMA;" | |||
There was a problem hiding this comment.
We need to make a similar change to the local docker compose setup too:
docker compose up
make examples
now fails because the btree_gist extension isn't installed.
| @@ -0,0 +1,56 @@ | |||
| { | |||
There was a problem hiding this comment.
Is it possible to give an example migration that doesn't require the btree_gist extension?
All the example migrations so far run against a vanilla Postgres - this is the first one that requires an extension.
| @@ -1020,6 +1020,191 @@ func TestCreateTable(t *testing.T) { | |||
| }, rows) | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
We could potentially just keep the first of these tests, which wouldn't require the extension.
Do you think that still provides enough coverage?
|
I think the simple test provides enough coverage already. I am happy to remove the more complex tests. \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new type of constraint to
create_tableoperation calledexcludeto support exclusion constraints.New options:
exclude.index_method: name of the index method (e.g. btree, gist, etc.)exclude.elements: exlusion elementsexclude.predicate: WHERE clause for partial indicesExample constraint forbidding overlap in room reservations:
{ "name": "52_create_table_with_table_exclusion_constraint", "operations": [ { "create_table": { "name": "room_reservations", "columns": [ { "name": "id", "type": "serial" }, { "name": "start", "type": "timestamp" }, { "name": "end", "type": "timestamp" }, { "name": "canceled", "type": "boolean", "default": "false" } ], "constraints": [ { "name": "forbid_double_booking", "type": "exclude", "exclude": { "index_method": "gist", "elements": "id WITH =, tsrange(\"start\", \"end\") WITH &&", "predicate": "NOT canceled" } } ] } } ] }The tests I added require the extension
btree_gist. So I added it formake examplesand runninggo test.