Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mls client initialization [WPB-15149] #3223

Merged
merged 10 commits into from
Jan 10, 2025
Merged

fix: mls client initialization [WPB-15149] #3223

merged 10 commits into from
Jan 10, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 10, 2025

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Port back fixes to 4.6 version

yamilmedina and others added 6 commits January 9, 2025 14:33
@yamilmedina
fix: fallback to proteus if conversation already present but MLS is d…
768b5d4 
…efault (WPB-15191) (#3200)

* fix: fallback to proteus if conversation already present and no common protocol

* fix: test coverage

* fix: test coverage
@ohassine @yamilmedina
fix: Migration message not shown in 1:1 conversations (#3042)
43fbe32
@yamilmedina
fix: update common protocol resolution (#3208)
8768576
@Garzas
fix: mls client init [WPB-15022] (#3178)
2152539 
* fix: secure mls client creation with is mls enabled

* fix: dont persist mls conversations when mls is disabled

* review improvements
@Garzas
fix: persist mls conversation when mls disabled (#3205)
eb7f6b9
@Garzas
Merge branch 'release/android-cycle-4.6' into fix/mls-client-initiali…
5bb04b2 
…zation
@Garzas Garzas self-assigned this Jan 10, 2025
@echoes-hq echoes-hq bot added the echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... label Jan 10, 2025
@Garzas Garzas enabled auto-merge (squash) January 10, 2025 12:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Test Results

2 926 tests   2 908 ✔️  6m 24s ⏱️
       7 suites       18 💤
       7 files           0 ❌

Results for commit 86cee9a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.15094% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/android-cycle-4.6@f9fcff1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../logic/data/conversation/ConversationRepository.kt 55.55% 5 Missing and 3 partials ⚠️
...ture/client/IsAllowedToRegisterMLSClientUseCase.kt 0.00% 4 Missing ⚠️
...om/wire/kalium/logic/feature/client/ClientScope.kt 0.00% 3 Missing ⚠️
...lium/logic/data/conversation/ConversationMapper.kt 50.00% 0 Missing and 2 partials ⚠️
...r/conversation/message/MLSMessageFailureHandler.kt 0.00% 0 Missing and 1 partial ⚠️
...persistence/dao/conversation/ConversationEntity.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##             release/android-cycle-4.6    #3223   +/-   ##
============================================================
  Coverage                             ?   58.54%           
  Complexity                           ?        7           
============================================================
  Files                                ?     1189           
  Lines                                ?    47098           
  Branches                             ?     4485           
============================================================
  Hits                                 ?    27572           
  Misses                               ?    17521           
  Partials                             ?     2005
Files with missing lines Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 27.09% <ø> (ø)
...wire/kalium/logic/data/client/MLSClientProvider.kt 21.56% <100.00%> (ø)
...gic/data/conversation/MLSConversationRepository.kt 83.87% <100.00%> (ø)
...ic/feature/keypackage/MLSKeyPackageCountUseCase.kt 71.87% <100.00%> (ø)
...r/conversation/message/MLSMessageFailureHandler.kt 33.33% <0.00%> (ø)
...persistence/dao/conversation/ConversationEntity.kt 98.41% <0.00%> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 58.13% <50.00%> (ø)
...om/wire/kalium/logic/feature/client/ClientScope.kt 0.00% <0.00%> (ø)
...ture/client/IsAllowedToRegisterMLSClientUseCase.kt 0.00% <0.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 61.43% <55.55%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fcff1...5bb04b2. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 10, 2025 •
edited
Loading

Datadog Report

Branch report: fix/mls-client-initialization
Commit report: 5839c9e
Test service: kalium-jvm

✅ 0 Failed, 2967 Passed, 108 Skipped, 22.71s Total Time

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Garzas Garzas merged commit 45ba664 into release/android-cycle-4.6 Jan 10, 2025
17 checks passed
@Garzas Garzas deleted the fix/mls-client-initialization branch January 10, 2025 15:02
@Garzas Garzas mentioned this pull request Jan 10, 2025
Merged
4 tasks
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

Assignees

@Garzas Garzas

Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 🚨 Potential breaking changes 👕 size: L type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garzas @codecov-commenter @yamilmedina @MohamadJaara @ohassine