encrypt *LB access logs if KMS key is specified #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit confused that setting a KMS key results in a policy that only allows writes using S3-SSE. I wonder if a new |
That's a much better idea, I'll refactor. |
ab77
force-pushed
the
ab77/encrypt-access-logs
branch
from
8408a72 to
a6f5bc4
Compare
@michaelwittig I've tested the new approach locally, works. |
ab77
force-pushed
the
ab77/encrypt-access-logs
branch
3 times, most recently
from
92f87c7 to
69b4be5
Compare
* only S3-SSE is available for *LB log delivery
ab77
force-pushed
the
ab77/encrypt-access-logs
branch
from
69b4be5 to
9883fe8
Compare
michaelwittig
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Override all values in parentheses)
(Run
yamllint folder/template.yaml,cfn-lint -i E1019 E3002 E2520 -t folder/template.yaml, andaws cloudformation validate-template --template-body file://folder/template.yamlbefore you open a PR)(Do not include multiple changes in one PR. Open additional PRs instead.)
Assume encryption of *LB access logs using S3-SSE if KMS key is provided.