Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Logcollector EventChannel Reader for Windows #465

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Implement Logcollector EventChannel Reader for Windows #465

wants to merge 16 commits into from

Conversation

LucioDonda
Copy link
Member

…windows

Related issue
Closes #206

Description

Configuration options

Logs/Alerts example

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation
  • Package installation
  • Source upgrade
  • Package upgrade
  • Review logs syntax and correct language
  • QA templates contemplate the added capabilities
  • Memory tests for Linux
    • Scan-build report
    • Coverity
    • Valgrind (memcheck and descriptor leaks check)
    • Dr. Memory
    • AddressSanitizer
  • Memory tests for Windows
    • Scan-build report
    • Coverity
    • Dr. Memory
  • Memory tests for macOS
    • Scan-build report
    • Leaks
    • AddressSanitizer
  • Retrocompatibility with older Wazuh versions
  • Working on cluster environments
  • Configuration on demand reports new parameters
  • The data flow works as expected (agent-manager-api-app)
  • Added unit tests (for new features)
  • Stress test for affected components
  • Decoder/Rule tests
    • Added unit testing files ".ini"
    • runtests.py executed without errors

@LucioDonda LucioDonda self-assigned this Dec 24, 2024
@LucioDonda LucioDonda linked an issue Dec 24, 2024 that may be closed by this pull request
Implement Logcollector EventChannel Reader for Windows #206
Open
10 tasks
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch from db0acba to 49a2def Compare January 6, 2025 11:55
gdiazlo
gdiazlo reviewed Jan 8, 2025
View reviewed changes
src/modules/logcollector/tests/unit/tempfile.hpp Outdated
{
auto error_msg = std::system_category().message(ec.value());

// Alternative approach using Windows API directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer portable APIs.

LucioDonda
LucioDonda commented Jan 8, 2025
View reviewed changes
src/modules/logcollector/src/another_reader_unix.cpp
@@ -0,0 +1,14 @@
#include <sstream>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file will be deleted

@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch from c621618 to a5e29ba Compare January 8, 2025 21:05
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch from 4d409e3 to 4aa0f54 Compare January 9, 2025 16:44
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch from 6dbeaf5 to 55632c7 Compare January 9, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdiazlo gdiazlo gdiazlo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LucioDonda LucioDonda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Logcollector EventChannel Reader for Windows
2 participants
@LucioDonda @gdiazlo