Skip to content

Commit

Permalink
Don't deny warnings on nightly CI (#1589)
Browse files Browse the repository at this point in the history
Too much churn!

Closes #1588
  • Loading branch information
alexcrichton authored Apr 24, 2020
1 parent d166cff commit d1be0c1
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/actions/install-rust/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ child_process.execFileSync('rustup', ['set', 'profile', 'minimal']);
child_process.execFileSync('rustup', ['update', toolchain, '--no-self-update']);
child_process.execFileSync('rustup', ['default', toolchain]);

// Deny warnings on CI to keep our code warning-free as it lands in-tree
console.log(`::set-env name=RUSTFLAGS::-D warnings`);
// Deny warnings on CI to keep our code warning-free as it lands in-tree. Don't
// do this on nightly though since there's a fair amount of warning churn there.
if (!toolchain.startsWith('nightly')) {
console.log(`::set-env name=RUSTFLAGS::-D warnings`);
}

// Save disk space by avoiding incremental compilation, and also we don't use
// any caching so incremental wouldn't help anyway.
Expand Down

0 comments on commit d1be0c1

Please sign in to comment.