Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demos: extend benchmark demo by can and ethernet #164

Merged
merged 11 commits into from
Jan 13, 2025

Conversation

VJonasHolley
Copy link
Collaborator

The Benchmark Demo has been extended by can and ethernet (so far only pubsub available). The service type can be determined via a command line argument (cf. silkit-1579).

Additional minor change: The simulation step size can be adapted via the command line.

Subject

Description

Instructions for review / testing

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

minor change: simulation step size as command line argument
@VJonasHolley VJonasHolley requested a review from KonradBkd January 7, 2025 10:26
Copy link
Contributor

@KonradBkd KonradBkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some crucial missing break; statements

Demos/Benchmark/BenchmarkDemo.cpp Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Outdated Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Outdated Show resolved Hide resolved
Demos/Benchmark/BenchmarkDemo.cpp Outdated Show resolved Hide resolved
VJonasHolley and others added 10 commits January 7, 2025 12:56
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com>
Copy link
Contributor

@KonradBkd KonradBkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@VJonasHolley VJonasHolley merged commit 1c72a10 into main Jan 13, 2025
13 checks passed
@VJonasHolley VJonasHolley deleted the silkit-1579_extension_benchmark_demo branch January 13, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants