From 307ff4856b9b2f0f6a31f517bbb50141913c4c53 Mon Sep 17 00:00:00 2001 From: Adi Roiban Date: Fri, 24 Jun 2016 14:49:41 +0100 Subject: [PATCH] Add and document codecov tests. --- CONTRIBUTING | 6 +++++- codecov.yml | 20 ++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 codecov.yml diff --git a/CONTRIBUTING b/CONTRIBUTING index ac394759a39..8b8ca45870d 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -24,5 +24,9 @@ https://twistedmatrix.com/trac/newticket Twisted uses Trac to keep track of bugs, feature requests, and associated patches because GitHub doesn't provide adequate tooling for its community. -For a PR to be accepted it needs to have at least all Travis CI tests passing. +For a PR to be accepted it needs to have: + +* all Travis CI tests passing +* patch coverage of 100% as reported by codecov.io + The Travis CI tests currently represent only a subset of the all the platforms Twisted supports, so the buildbot tests are still the actual gate for PR acceptance. diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 00000000000..fc58f686c70 --- /dev/null +++ b/codecov.yml @@ -0,0 +1,20 @@ +# +# We want %100 coverage for new patches to make sure we are always increasing +# the coverage. +# +# For now codecov.io has no way to fail if project overall coverage is +# decreased... but I think this is hard as for example if we deprecated and +# remove some code which is well covered we might end up with a smaller +# coverage. +# +coverage: + precision: 2 + round: down + status: + patch: + default: + target: 100% + +comment: + layout: "header, diff, uncovered" + behavior: default