Parse Error with ZMK_HOLD_TAP / MAKE_HRM #63

carbsoncream · 2024-11-30T20:06:02Z

carbsoncream
Nov 30, 2024

I am trying to implement the zmk-helper package to prepare keymap for sofle. When I simply copy and paste the MAKE_HRM(hml, &kp, &kp, KEYS_R THUMBS) and corresponding #define... lines, the error message at the exact line of MAKE_HRM(...) showed up.

The code:

// ...
#include "zmk-helpers/helper.h"

#define MAKE_HRM(NAME, HOLD, TAP, TRIGGER_POS) \
    ZMK_HOLD_TAP(NAME, \
        flavor = "balanced"; \
        tapping-term-ms = <280>; \
        quick-tap-ms = <QUICK_TAP_MS>; \
        require-prior-idle-ms = <150>; \
        bindings = <HOLD>, <TAP>; \
        hold-trigger-key-positions = <TRIGGER_POS>; \
        hold-trigger-on-release; \
    )
MAKE_HRM(hml, &kp, &kp, KEYS_R THUMBS)  // <------ line 310 causing devicetree error
MAKE_HRM(hmr, &kp, &kp, KEYS_L THUMBS)  // right-hand HRMs

// ...

The error message:

devicetree error: /__w/zmk-config/zmk-config/config/sofle.keymap:310 (column 213): parse error: expected number or parenthesized expression
CMake Error at /__w/zmk-config/zmk-config/zephyr/cmake/modules/dts.cmake:279 (message):
  gen_defines.py failed with return code: 1
Call Stack (most recent call first):
  /__w/zmk-config/zmk-config/zephyr/cmake/modules/zephyr_default.cmake:129 (include)
  /__w/zmk-config/zmk-config/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  /__w/zmk-config/zmk-config/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
  CMakeLists.txt:8 (find_package)


-- In: /tmp/tmp.HYCMl4fGHo/zephyr, command: /usr/bin/python3;/__w/zmk-config/zmk-config/zephyr/scripts/dts/gen_defines.py;--dts;/tmp/tmp.HYCMl4fGHo/zephyr/zephyr.dts.pre;--dtc-flags;'';--bindings-dirs;/__w/zmk-config/zmk-config/zmk/app/module/dts/bindings;/__w/zmk-config/zmk-config/zmk/app/dts/bindings;/__w/zmk-config/zmk-config/zephyr/dts/bindings;--header-out;/tmp/tmp.HYCMl4fGHo/zephyr/include/generated/devicetree_generated.h.new;--dts-out;/tmp/tmp.HYCMl4fGHo/zephyr/zephyr.dts.new;--edt-pickle-out;/tmp/tmp.HYCMl4fGHo/zephyr/edt.pickle;--vendor-prefixes;/__w/zmk-config/zmk-config/zmk/app/dts/bindings/vendor-prefixes.txt;--vendor-prefixes;/__w/zmk-config/zmk-config/zephyr/dts/bindings/vendor-prefixes.txt
-- Configuring incomplete, errors occurred!
FATAL ERROR: command exited with status 1: /usr/local/bin/cmake -DWEST_PYTHON=/usr/bin/python3 -B/tmp/tmp.HYCMl4fGHo -GNinja -DBOARD=sofle_right -DZMK_CONFIG=/__w/zmk-config/zmk-config/config -S/__w/zmk-config/zmk-config/zmk/app

ZMK_LAYER(...) works perfects with the exisitng key map and I crave to use zmk-helpers for production. But I have been spending hours to study and still had no clue for what could be done to overcome the issue with MAKE_HRM(...). Is there any solution or work-a-round for that?

urob · 2024-11-30T23:24:17Z

urob
Nov 30, 2024
Maintainer

Me guess would be some missing definitions but hard to say without seeing your config. If you add a link I can take a look.

1 reply

carbsoncream Dec 1, 2024
Author

The files were messy and terrible after the debug. I'll try to tidy it up and at the same time review the definitions in details. Thanks Rob.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse Error with ZMK_HOLD_TAP / MAKE_HRM #63

{{title}}

Replies: 1 comment 1 reply

{{title}}

{{title}}

Select a reply

Parse Error with ZMK_HOLD_TAP / MAKE_HRM #63

carbsoncream Nov 30, 2024

Replies: 1 comment · 1 reply

urob Nov 30, 2024 Maintainer

carbsoncream Dec 1, 2024 Author

carbsoncream
Nov 30, 2024

Replies: 1 comment 1 reply

urob
Nov 30, 2024
Maintainer

carbsoncream Dec 1, 2024
Author