Skip to content

Commit

Permalink
Merge bitcoin#23072: log: Remove unnecessary timing of Callbacks bench
Browse files Browse the repository at this point in the history
ab27800 log: Remove unnecessary timing logs for Callbacks bench (Douglas Chimento)

Pull request description:

  Logging of Callbacks are no longer needed and records times that are not relevant for performance analysis.
  resolves bitcoin#23071

ACKs for top commit:
  laanwj:
    Thanks. re-ACK ab27800
  jonatack:
    Code review ACK ab27800

Tree-SHA512: be1ea780c4db9407a8799065a8824b9d3610abac72af5907809ed62d493d5a54e65735de45ec5fdd0edb85ef21ec6036105abe8ca00093942980f6f92e7fec50
  • Loading branch information
merge-script committed Sep 23, 2021
2 parents cdce149 + ab27800 commit 95b16e7
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/validation.cpp
Original file line number Diff line number Diff line change
@@ -1572,7 +1572,6 @@ static int64_t nTimeForks = 0;
static int64_t nTimeVerify = 0;
static int64_t nTimeConnect = 0;
static int64_t nTimeIndex = 0;
static int64_t nTimeCallbacks = 0;
static int64_t nTimeTotal = 0;
static int64_t nBlocksTotal = 0;

@@ -1877,9 +1876,6 @@ bool CChainState::ConnectBlock(const CBlock& block, BlockValidationState& state,
int64_t nTime5 = GetTimeMicros(); nTimeIndex += nTime5 - nTime4;
LogPrint(BCLog::BENCH, " - Index writing: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime5 - nTime4), nTimeIndex * MICRO, nTimeIndex * MILLI / nBlocksTotal);

int64_t nTime6 = GetTimeMicros(); nTimeCallbacks += nTime6 - nTime5;
LogPrint(BCLog::BENCH, " - Callbacks: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime6 - nTime5), nTimeCallbacks * MICRO, nTimeCallbacks * MILLI / nBlocksTotal);

TRACE7(validation, block_connected,
block.GetHash().ToString().c_str(),
pindex->nHeight,

0 comments on commit 95b16e7

Please sign in to comment.