Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to support any ClickHouse aggregate function in queries? #369

Open
azat opened this issue Apr 25, 2024 · 2 comments
Open

Is it possible to support any ClickHouse aggregate function in queries? #369

azat opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@azat
Copy link

azat commented Apr 25, 2024

ClickHouse has reach aggregation functions support.

Right now it requires custom parsing, and so we can't use all the power.

Is it a significant amount of work to parse any functions and pass them as-is to ClickHouse?
@vmihailenco
Copy link
Member

Functions with a single argument are trivial to support and don't requires changing the parser. Just add your function here and send a PR.

For functions with 2+ arguments we need to change the parser, but it is just a limitation of the current approach and we probably can remove it.

What functions would you like to see?

@vmihailenco vmihailenco added the enhancement New feature or request label Apr 27, 2024
@azat
Copy link
Author

azat commented Apr 27, 2024

Just add your function here and send a PR.

Maybe it could be done automatically, i.e. initialize list of functions with select * from system.functions where is_aggregate and then allow any of them, or simply allow all of them, and just return an error if the function doesn't exist?

What functions would you like to see?

I'm not sure for now, I just thought about providing simple alternative for splunk with uptrace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmihailenco @azat