Added locked state on list cell renderer #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenCoogan
requested review from
Xegushu and
JulienVannier66
and removed request for
a team
phndiaye
reviewed
Dec 31, 2024
| @@ -8,6 +8,7 @@ export default Component.extend(CellRendererMixin, { | |||
| }), | |||
|
|
|||
| isEditing: false, | |||
| locked: this?.column?.locked ?? false, | |||
There was a problem hiding this comment.
can you make this a computed instead ?
phndiaye
reviewed
Dec 31, 2024
Comment on lines
+89
to
+95
| cell_renderers: | ||
| no_permission: | ||
| mailings: You don't have permission to access this mailing | ||
| lists: You don't have permission to access this list | ||
| campaigns: You don't have permission to access this campaign | ||
| tracking_plans: You don't have permission to access this tracking plan | ||
| acquisition_campaigns: You don't have permission to access this live capture campaign |
There was a problem hiding this comment.
not super fan of having this in this project tbh. it's highly bound to upfluence context which this project isn't. we can discuss it live if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to : #
What are the observable changes?
π§βπ» Developer Heads Up
β‘ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes