Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for dark mode toggling via keyboard #3526

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Allow for dark mode toggling via keyboard #3526

wants to merge 2 commits into from

Conversation

06b
Copy link

@06b 06b commented Oct 21, 2022

The following changes were made:

  • Improve website accessibility #912
    • Adjusted the dark mode toggle to be accessible via keyboard navigation.
  • Improving Frontend #930
    • Removed commented out light/dark mode styles from stylesheet.
      • Removed inline styles being set via JavaScript back to the stylesheet.
    • Set toggling of theme preference styling via [data-theme-preference] attribute on the html element.

@ritwik12
Copy link
Collaborator

@06b How can one change dark mode from keyboard with this? Which buttons?

@ritwik12 ritwik12 added the has questions Reviewer has outstanding questions about the pull request label Dec 19, 2022
@06b
Copy link
Author

06b commented Dec 19, 2022

@ritwik12 When the theme-selector button has keyboard focus a person can press either the space or enter key and it will toggle the styles.

@ritwik12 ritwik12 requested a review from shiftkey March 19, 2023 21:12
@shiftkey
Copy link
Member

@06b apologies for the delay in reviewing this, but it seems like there are conflicts here which I'm not sure how to resolve. Are you able to take a look at this branch and get it back to a working state?

@shiftbot
Copy link
Contributor

shiftbot commented Aug 28, 2023 •
edited
Loading

👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under _data/projects/ so I don't have any feedback here.

As you make changes to this pull request, I'll re-run these checks.

@06b
Copy link
Author

06b commented Aug 28, 2023

@shiftkey Yeah, that didn't go as planned. If it's alright with you, I'll close this pull request and when I get sometime in the future I'll try again and ping you?

@shiftkey shiftkey force-pushed the Dark-Mode-Toggling-Keyboard-Improvements branch from 9727d7a to e561d6e Compare August 28, 2023 00:49
@shiftkey
Copy link
Member

@06b all good, I've taken a shot at rebasing and squishing the history. I'll drop some notes in here about what I did but hopefully this branch gets us into a good spot for validating the changes...

@shiftkey
Copy link
Member 

> git checkout Dark-Mode-Toggling-Keyboard-Improvements
# fetch the latest changes from the base branch
> git fetch origin gh-pages
# clobber the history but leave the modified files between your branch and `gh-pages` in the working directory
> git reset origin/gh-pages
# there might be additional files here that require cleanup
> [stage files for commit]
# create a single commit with just the desired changes
> git commit
# force push to rewrite history
> git push --force-with-lease

@shiftkey shiftkey added needs review and removed has questions Reviewer has outstanding questions about the pull request labels Aug 28, 2023
@shiftkey @06b
Allow for dark mode toggling via keyboard
d0e75fc 
Co-authored-by: Adrian D. Alvarez <1302542+06b@users.noreply.github.com>
@shiftkey shiftkey force-pushed the Dark-Mode-Toggling-Keyboard-Improvements branch from 0bed74b to d0e75fc Compare August 10, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guibranco guibranco guibranco approved these changes

@shiftkey shiftkey Awaiting requested review from shiftkey

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@06b @ritwik12 @shiftkey @shiftbot @guibranco