Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'underscores' scss files as a dependency #320

Open
bacoords opened this issue Dec 13, 2021 · 3 comments
Open

Remove 'underscores' scss files as a dependency #320

bacoords opened this issue Dec 13, 2021 · 3 comments
Assignees
@bacoords @kirannasim
Milestone
1.2.0

Comments

@bacoords
Copy link
Member

It's time to reevaluate whether we need the the /src/sass/underscores/ dependency at all. It doesn't exist in the parent theme and much of the code is duplicated in the _understrap.scss file anyway.

I suggest we delete the directory and remove @import "assets/underscores"; from /src/sass/child-theme.scss.
@bacoords bacoords self-assigned this Dec 13, 2021
@0dp
Copy link
Contributor

0dp commented Dec 14, 2021 •
edited
Loading

I raised this assumption long time ago.
It's time imo to move away from the 'based on underscores'

Also the only dependency we are using from the npm package is the skip link i think

@bacoords
Copy link
Member Author

I assume we'll always keep 'based on underscores' for SEO, visibility, legacy reasons. Plus it's in the name Understrap (not that a new name would be the worst thing), but since we don't even pull these SCSS files in the parent theme, I see no reason to keep them here.

@bacoords bacoords added this to the 1.2.0 milestone Feb 3, 2022
@kirannasim
Copy link

just removed underscores SCSS files

#343

@kirannasim kirannasim self-assigned this Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bacoords bacoords

@kirannasim kirannasim

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@0dp @bacoords @kirannasim