Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seventh reconciliation PR from production/RRFS.v1 #2530

Merged
merged 21 commits into from
Jan 3, 2025

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Dec 5, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This is work from @haiqinli and is identical to #2343 except it targets the develop branch.

  • to compile the model with new fms/2024.01

  • Update the RUC LSM deep soil temperature from climatology to real forecast.

Commit Message:

* UFSWM - to compile the model with new fms/2024.01; Update the RUC LSM deep soil temperature from climatology to real forecast
  * FV3 - to compile the model with new fms/2024.01; Update the RUC LSM deep soil temperature from climatology to real forecast
    * ccpp-physics - Update the RUC LSM deep soil temperature from climatology to real forecast

Priority:

  • High: Needed for SRW App

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn (skip)
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl grantfirl marked this pull request as ready for review December 19, 2024 19:46
@grantfirl
Copy link
Collaborator Author

The full RTs are running on Hera and are almost finished. Tests that use the RUC LSM are expected to change baseline results. I'll upload the logs when the tests complete.

@grantfirl
Copy link
Collaborator Author

The changed baseline results are as expected given the code changes.

@jkbk2004
Copy link
Collaborator

@grantfirl as #2529 has an issue, we like to move on working on this pr. Sorry about my last commit to the branch: I was confused. I think I fixed ok. Can you sync up branches? So we can go ahead for testing.

@grantfirl
Copy link
Collaborator Author

@grantfirl as #2529 has an issue, we like to move on working on this pr. Sorry about my last commit to the branch: I was confused. I think I fixed ok. Can you sync up branches? So we can go ahead for testing.

@jkbk2004 OK, should be good to test now. Everything is synced up.

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Dec 31, 2024
@BrianCurtis-NOAA
Copy link
Collaborator

Skip Acorn, still working through some permissions issues there.

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 A couple questions: Are we running ORT's any more. Has the PR template been updated since we starting running both gaea c6 and gaea c5 RT's?

@jkbk2004 jkbk2004 added the jenkins-ort run ORT testing label Jan 2, 2025
@jkbk2004 jkbk2004 removed the jenkins-ort run ORT testing label Jan 3, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 3, 2025

We can start merging process.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 3, 2025

@grantfirl new FV3 hash is NOAA-EMC/fv3atm@0834c7b

@jkbk2004 jkbk2004 merged commit 76471dc into ufs-community:develop Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants