Add hint when hypertable creation fails #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpan2034
force-pushed
the
improve-error-msg
branch
2 times, most recently
from
03a3666 to
4a380db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7565 +/- ##
==========================================
+ Coverage 80.06% 82.29% +2.22%
==========================================
Files 190 238 +48
Lines 37181 43718 +6537
Branches 9450 10970 +1520
==========================================
+ Hits 29770 35978 +6208
- Misses 2997 3402 +405
+ Partials 4414 4338 -76 ☔ View full report in Codecov by Sentry. |
kpan2034
force-pushed
the
improve-error-msg
branch
from
4a380db to
de0028f
Compare
svenklemm
approved these changes
Jan 2, 2025
kpan2034
force-pushed
the
improve-error-msg
branch
from
de0028f to
3f152e9
Compare
antekresic
approved these changes
Jan 8, 2025
kpan2034
force-pushed
the
improve-error-msg
branch
2 times, most recently
from
65b8306 to
9e1c200
Compare
When creating a hypertable, we create default indexes on the partition column, which requires that the column be a part of the table's primary or composite key. The error message shown to the user in this scenario did not indicate this correctly. This adds a hint to make this clearer. Closes timescale#2907.
kpan2034
force-pushed
the
improve-error-msg
branch
from
9e1c200 to
d186781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a hypertable, we create default indexes on the partition column, which requires that the column be a part of the table's primary or composite key. The error message shown to the user in this scenario did not indicate this correctly. This adds a hint to make this clearer.
Closes #2907.