improve error reporting when spawnProcess raises

thinhld80 · Mar 21, 2023 · 2c001a9 · 2c001a9
1 parent 1278640
commit 2c001a9
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/src/twisted/internet/test/test_process.py b/src/twisted/internet/test/test_process.py
@@ -446,14 +446,20 @@ def processEnded(self, reason):
 
         reactor = self.buildReactor()
 
-        reactor.callWhenRunning(
-            reactor.spawnProcess,
-            GatheringProtocol(),
-            pyExe,
-            [pyExe, b"-Wignore", b"-c", source],
-            env=properEnv,
-            usePTY=self.usePTY,
-        )
+        def doSpawn() -> None:
+            try:
+                reactor.spawnProcess(
+                    GatheringProtocol(),
+                    pyExe,
+                    [pyExe, b"-Wignore", b"-c", source],
+                    env=properEnv,
+                    usePTY=self.usePTY,
+                )
+            except BaseException:
+                err()
+                reactor.stop()
+
+        reactor.callWhenRunning(doSpawn)
 
         self.runReactor(reactor)
         reportedChildFDs = set(eval(output.getvalue()))