Clarify the contract of Response#ok, and avoid exceptions in it

thebigw4lrus · Oct 3, 2015 · 086e19d · 086e19d
1 parent 443d07e
commit 086e19d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/requests/models.py b/requests/models.py
@@ -616,11 +616,8 @@ def __iter__(self):
 
     @property
     def ok(self):
-        try:
-            self.raise_for_status()
-        except HTTPError:
-            return False
-        return True
+        """True if the status code does *not* indicate an error, i.e. status code < 400."""
+        return self.status_code < 400
 
     @property
     def is_redirect(self):