feat: improve error handling

ref: #28 ref: #28 (comment)
tbdsux · May 31, 2023 · 94df261 · 94df261 · vercel · May 31, 2023
1 parent e8cde46
commit 94df261
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -56,6 +56,30 @@ https://kuryana.vercel.app/seasonal/{year}/{quarter}
 https://kuryana.vercel.app/list/{id}
 ```
 
+### Error Messages
+
+```js
+// mainly on all endpoints except `search`
+// sample: /list/unknown-random-id
+{
+  "code": 400,
+  "error": true,
+  "description": {
+    "title": "This list is private.",
+    "info": "You can see this page because the URL you are accessing cannot be found."
+  }
+}
+```
+
+```js
+// could also be this (only on `/search`) endpoint
+{
+  "error": true,
+  "code": 404,
+  "description": "404 Not Found"
+}
+```
+
 ## Development
 
 - Using the vercel CLI (`localhost:3000`)

diff --git a/api/parser.py b/api/parser.py
@@ -75,9 +75,19 @@ def res_get_err(self) -> Dict[str, Any]:
         err: Dict[str, Any] = {}
 
         try:
-            err["status_code"] = self.status_code
-            err["error"] = container.find("div", class_="box-body").find("h1").text
-            err["info"] = container.find("div", class_="box-body").find("p").text
+            err["code"] = self.status_code
+            err["error"] = True
+            err["description"] = {
+                "title": container.find("div", class_="box-body")
+                .find("h1")
+                .get_text()
+                .strip(),
+                "info": container.find("div", class_="box-body")
+                .find("p")
+                .get_text()
+                .strip(),
+            }
+
         except Exception:
             pass
 

diff --git a/api/utils.py b/api/utils.py
@@ -41,7 +41,7 @@ async def fetch_func(query: str, t: str) -> Tuple[int, Dict[str, Any]]:
 
     f = await fs[t].scrape(query=query, t="page")
     if not f.ok:
-        return f.status_code, error(f.status_code, "An unexpected error occurred.")
+        return f.status_code, f.res_get_err()
     else:
         f._get()