-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Passing Window to Snap User Actions and Introduce Configurable Snap Name List #1629
Merged
AndreasArvidsson
merged 18 commits into
talonhub:main
from
jaresty:use-talon-list-for-snap-position-names
Jan 11, 2025
Merged
Allow Passing Window to Snap User Actions and Introduce Configurable Snap Name List #1629
AndreasArvidsson
merged 18 commits into
talonhub:main
from
jaresty:use-talon-list-for-snap-position-names
Jan 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This extracts the snap positions as a talon list and exposes a public method to use them - It falls back if users are using the existing names directly
- use programmatic formatting instead of static map - show deprecation warning
jaresty
changed the title
Extracts snap positions as a talon list
Allow Passing Optional Window to Snap User Actions
Dec 2, 2024
phillco
reviewed
Dec 3, 2024
- Update docstrings. - Make explicit case for when an invalid position name is passed
AndreasArvidsson
requested changes
Dec 3, 2024
- Used deprecate action instead of deprecate command since this is an API change instead of a spoken form change. - Introduced an optional argument to suggest a replacement action on deprecate action. If the argument is not provided it will not mention the replacement action in the notification.
for more information, see https://pre-commit.ci
AndreasArvidsson
approved these changes
Dec 12, 2024
nriley
previously requested changes
Dec 14, 2024
Can you make the title reflect everything the change does? |
jaresty
changed the title
Allow Passing Optional Window to Snap User Actions
Allow Passing Window to Snap User Actions and Introduce Configurable Snap Name List
Dec 15, 2024
Adjusted the title to mention the new talon list. Let me know if you think I should add more. |
phillco
approved these changes
Jan 11, 2025
Ah weird @nriley's old requested changes was keeping this one in the "reviewed needed" state even though a new review had been requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We want to be able to call these snap positions from another module (#1578), but the existing action takes a spoken form. We'd rather not build a dependency on those, because they can be brittle if the user changes them; it's become a best practice recently (formatters, etc) to use static identifiers instead, and use a Talon list to provide the spoken form.
Change: