Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Card story with missing variants #1236

Open
Traxmaxx opened this issue Nov 27, 2023 · 4 comments · May be fixed by #1262
Open

Update Card story with missing variants #1236

Traxmaxx opened this issue Nov 27, 2023 · 4 comments · May be fixed by #1262
Assignees
@ManishBisht777
Labels
enhancement New feature or request frontend ui

Comments

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Nov 27, 2023 •
edited
Loading

The Card story inside Storybook seems to not support all variants accordingt to Figma. Please make sure the implementation and Storybook story is supporting all variants from Figma.

Screenshot 2023-11-27 at 12 55 48

https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=1747-12818&mode=dev

You will find a short intro into our Storybook setup in the Dashboard README
@Traxmaxx Traxmaxx added enhancement New feature or request frontend labels Nov 27, 2023
@Traxmaxx Traxmaxx changed the title Update card story with missing variants Update Card story with missing variants Nov 27, 2023
@AllieMendes AllieMendes added the ui label Nov 27, 2023
@ManishBisht777
Copy link
Contributor

I would like to work on this issue

@AllieMendes
Copy link

Hey @ManishBisht777!
I've assigned it to you, let me know your email so I can invite you to the Design System on Figma

@ManishBisht777
Copy link
Contributor

Hey @AllieMendes
here's my email manishbisht9711@gmail.com

@AllieMendes
Copy link

I've sent an invitation, let me know if you have any questions or feedback on the component documentation :)

@ManishBisht777 ManishBisht777 linked a pull request Dec 4, 2023 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManishBisht777 ManishBisht777

Labels
enhancement New feature or request frontend ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEAT-1236] Add Card Variants to Storybook ManishBisht777/komiser
3 participants
@Traxmaxx @ManishBisht777 @AllieMendes