Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taiko-client): changes based on Pacaya fork #18746

Open
wants to merge 141 commits into
base: pacaya_fork
Choose a base branch
from
Open

feat(taiko-client): changes based on Pacaya fork #18746

wants to merge 141 commits into from

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Jan 10, 2025 •
edited
Loading

TODO:

  • add more tests for Pacaya changes
  • test legacy Ontake code
  • fix current tests, need @YoGhurt111 to add OP verifier at first
  • improve current code
  • add preconf block API server
  • add preconf blocks P2P network
  • do not reorg the current chain when there is a BatchProposed event

@davidtaikocha davidtaikocha changed the base branch from pacaya_fork to pacaya_subblocks January 10, 2025 07:28
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 10, 2025 •
edited
Loading

feat(taiko-client): changes based on Pacaya fork

Generated at commit: 34c57ee255dd18ab94e680bb33eab44b6be4bbc3

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
10
40
56
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Base automatically changed from pacaya_subblocks to pacaya_fork January 13, 2025 02:41
@davidtaikocha davidtaikocha mentioned this pull request Jan 25, 2025
Open
@davidtaikocha
Copy link
Member Author

@davidtaikocha we need to check if the resolver has a preconf_router set, and if so, we need to use the generated PreconfROuter to propose blocks through - otherwise, we use the TaikoInbox.

changed: 9c9e47a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

@mask-pp mask-pp Awaiting requested review from mask-pp

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

Assignees
No one assigned
Labels
area.client category.feature option.do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidtaikocha @cyberhorsey @YoGhurt111 @mask-pp @RogerLamTd