Update players.py to incorporate accent neutral search #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accent neutral/normalization search function
|
@mxufc29 - Please move the unit test into tests/unit. The project uses pytest. file name should be test_players.py. Other than that, all looks good. Let me know when you've made the update. Thanks! |
|
@rsforbes ok got it, thanks! Just separated and moved the unit test into that location, tests/unit/test_players.py, so should be good to go. let me know if any other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted in response to issue 484 - #484
Incorporated accent neutral searching for _find_players(regex_pattern, row_id, players=players) via addition of the _strip_accents(inputstr: str) function.
Unit testing/test cases included in main. The results and test cases then outputted to console for review.
This is my first pull request! So let me know if there is anything else I can do or if anything is unclear.