namespace resource should be close after alloca success.

swapwz · Dec 5, 2017 · d4ce146 · d4ce146
1 parent f47db0b
commit d4ce146
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/veth/veth.go b/pkg/veth/veth.go
@@ -103,11 +103,11 @@ func JoinNetNS(name string, nspath string) error {
     // move link to specified namespace
     if nspath != "" {
         netns, err := ns.GetNS(nspath)
-        defer netns.Close()
         if err != nil {
             fmt.Fprintf(os.Stderr, "[UNION CNI] failed to open netns %q: %v\r\n", nspath, err)
             return err
         }
+        defer netns.Close()
         if err := netlink.LinkSetNsFd(link, int(netns.Fd())); err != nil {
             fmt.Fprintf(os.Stderr, "[UNION CNI] failed to move link %q to netns: %v\r\n", name, err) 
             return err