You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.
The tailwind adder is broken right now (#459). It'd be nice if we had tests that could catch that before a PR gets merged
Describe the solution you'd like
Use vitest fixtures. Check that the generated project matches what is expected. That will also help us in code review because we can look at the generated project and see what we think about the diff. We can also setup a script in the package.json to automatically update the fixtures so that they're not hard to maintain when we make changes to the code
The text was updated successfully, but these errors were encountered:
I don't think that it really is. The other issue would just make sure that Welcome to Sveltkit (or whatever) is rendered. But this would be way better for code review and so one.
The only thing that makes me re-consider this is making vitest work with the adders. I tried this in the past, and failed. But we might have a better chance now that #446 is implemented.
Topic
all
Description
The tailwind adder is broken right now (#459). It'd be nice if we had tests that could catch that before a PR gets merged
Describe the solution you'd like
Use vitest fixtures. Check that the generated project matches what is expected. That will also help us in code review because we can look at the generated project and see what we think about the diff. We can also setup a script in the package.json to automatically update the fixtures so that they're not hard to maintain when we make changes to the code
The text was updated successfully, but these errors were encountered: