Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

tests with fixtures #461

Open
benmccann opened this issue Jul 1, 2024 · 3 comments
Open

tests with fixtures #461

benmccann opened this issue Jul 1, 2024 · 3 comments
Labels
enhancement New feature or request solved-by-rewrite

Comments

@benmccann
Copy link
Collaborator

Topic

all

Description

The tailwind adder is broken right now (#459). It'd be nice if we had tests that could catch that before a PR gets merged

Describe the solution you'd like

Use vitest fixtures. Check that the generated project matches what is expected. That will also help us in code review because we can look at the generated project and see what we think about the diff. We can also setup a script in the package.json to automatically update the fixtures so that they're not hard to maintain when we make changes to the code

@benmccann benmccann added the enhancement New feature or request label Jul 1, 2024
@benmccann
Copy link
Collaborator Author

oh, I just noticed that this is a bit of a duplicate of #356

@manuel3108
Copy link
Member

I don't think that it really is. The other issue would just make sure that Welcome to Sveltkit (or whatever) is rendered. But this would be way better for code review and so one.

The only thing that makes me re-consider this is making vitest work with the adders. I tried this in the past, and failed. But we might have a better chance now that #446 is implemented.

@manuel3108
Copy link
Member

Is it possible that you mean snapshots? I could not find much about fixtures in their docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request solved-by-rewrite
Projects
None yet
Development

No branches or pull requests

2 participants