Jenkins Builds

@shivekkhurana
at attempt to reset password after entering old and new password got error:

96% of end-end tests have passed

Total executed tests: 70
Failed tests: 3
Passed tests: 67

IDs of failed tests: 5309,6263,6249 

Failed tests (3)

Passed tests (67)

This will unblock #11777

@shivekkhurana thank you for work!
Several issues:

ISSUE 1: Can tap "next" several times on reset password screen

Steps:

1. restore multiaccount from seed phrase
2. go to Security > Reset password
3. enter passwords
4. tap "Next" several times

Expected result:
"Next" can be tapped only once

Actual result:

OS: IOS, Android

ISSUE 2: Automatic logout doesn't work after resetting password until relogin

Steps:

1. restore multiaccount from seed phrase
2. reset password
3. go to Advanced > Network > change Network

Expected result: should be logged out

Actual result: is not logged out

ISSUE 3: Reset password is available for keycard users

ISSUE 4: Endless spinner if resetting password with enabled biometric login (IOS only)

Steps:

1. restore multiaccount from seed phrase
2. enable biometric login
3. reset password
4. reopen app
   In case of Android after attempt to login user stays on login screen with "Wrong password" error - suppose this is expected behaviour
   In case of IOS - blank screen with endless spinner
   
   status_logs.zip

90% of end-end tests have passed

Total executed tests: 70
Failed tests: 7
Passed tests: 63

IDs of failed tests: 6251,6645,5309,6646,6249,6237,6290 

Failed tests (7)

Passed tests (63)

@churik

ISSUE 1: Can tap "next" several times on reset password screen

✅ Added an overlay that cannot be closed until password reset is complete. The user can no longer press the next button.

ISSUE 3: Reset password is available for keycard users

✅ Fixed

ISSUE 4: Endless spinner if resetting password with enabled biometric login (IOS only)

🤞🏼 The problem was that password reset didn't update the password in OS keychain. Have fixed it now, should work hopefully

ISSUE 2: Automatic logout doesn't work after resetting password until relogin
Steps:

1. restore multiaccount from seed phrase
2. reset password
3. go to Advanced > Network > change Network

I feel this is a problem in multiaccount recovery flow. I checked resetting password and then changing network on an existing account. It worked fine.

Can you please confirm this is not an issue if step 1 is removed?

Can you please confirm this is not an issue if step 1 is removed?

Well, if I create multiaccount from scratch, reset password, and change network - no autologout.
Tested on latest build with 8edd260 commit

@churik All issues fixed.

@shivekkhurana
thank you!
I can still tap next several times, but it is not a big deal now as we have automatic logout after.
So considering it as ready to be merged.

@churik

I can still tap next several times

I'm not able to understand this. When you fill the form and press the next button, an overlay should cover the screen.

It is not possible to close the overlay, until the password reset is complete, in which case the only way to proceed is to logout or close the app.

Can you give me the steps to reproduce the behaviour you see?

[SELF NOTE] Get rid of feature flag before merging.

Sure. The way to reproduce it is to be quick enough to tap "Next" several times before overlay is shown.
But as I said it is quite edge case - and only the issue that that error is shown in background.

I understand now. I'll push a fix tomorrow.

@churik I have added a condition that disables the Next > button when the password is resetting. In terms of the UI, it might not seem obvious (ie. it might feel that you are able to press the button), but multiple requests are not made.

Ready to be merged.