This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
Improve python3 support #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2018 17:56
In python 3 long and int types have been unified and it is no longer legal to use the L postfix to declare a long. As this postfix is used in snakebite it fails under python 3. This commit improves python 3 support for some use cases. It is not intended to make snakebite fully python 3 compatible in any way but just to remove a common issue. This changes allows limited functionality under python 3 which is enough for many usecases.
|
I have added a second commit so that the tests pass. travis seems to have removed their python 2.6 environments. I can remove this is desired |
|
Very appreciated if the change in snakebite/client.py could be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3
longandinttypes have been unified and it is no longerlegal to use the L postfix to declare a long. As this postfix is used
in snakebite it fails under python 3. This commit improves python 3
support for some use cases.
It is not intended to make snakebite fully python 3 compatible in any
way but just to remove a common issue. This changes allows limited
functionality under python 3 which is enough for many use-cases.
This is basically a clean version of #203 and a simplification of #239 although maybe the changes to
channel.pyshould be considered, but since they do not affect me I've not added them.The impact on the codebase is minimal and this simple change can make a huge difference to users of python 3.x