This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
Stop mv on error #233
Open
Stop mv on error #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in spotify#232, continuing mv after an error can have unexpected bad results. By stopping the mv, we leave it up to the user how to resolve the situation.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #232, continuing mv after an error can have unexpected bad results. By stopping the mv, we leave it up to the user how to resolve the situation.
Using the same test script as in #232, this stops after the failure trying to move
/tmp/test_trash/aand does not move/tmp/test_trash/a/b.