Code cleanup, update doc

sonh · Jun 9, 2021 · 8e03ada · 8e03ada
1 parent bfdeb5e
commit 8e03ada
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@
 Package sonh/qs encodes structs into url.Values.
 
 ## Installation
-```shell
+```bash
 go get github.com/sonh/qs
 ```
 
@@ -166,9 +166,9 @@ fmt.Println(values.Encode()) //(unescaped) output: "user[from]=1601623397728&use
 ```
 
 ### Custom Type
-Implement `EncodeParam` to encode itself into query param.
-
-Implement `IsZero` to check whether an object is zero to determine whether it should be omitted when encoding.
+Implement funcs:
+* `EncodeParam` to encode itself into query param.
+* `IsZero` to check whether an object is zero to determine whether it should be omitted when encoding.
 ```go
 type NullableName struct {
 	First string

diff --git a/encode.go b/encode.go
@@ -235,11 +235,6 @@ func (e *encoder) structCaching(fields *cachedFields, stVal reflect.Value, scope
 
 		fieldTyp := getType(fieldVal)
 
-		/*if formatter := e.e.formatters[fieldTyp]; formatter != nil {
-			*fields = append(*fields, newCustomField(fieldTyp, e.tags[0], e.tags[1:], formatter))
-			continue
-		}*/
-
 		if fieldTyp == timeType {
 			*fields = append(*fields, newTimeField(e.tags[0], e.tags[1:]))
 			continue

diff --git a/example/basic/basic.go b/example/basic/basic.go
@@ -27,7 +27,7 @@ func main() {
 	values, err := encoder.Values(query)
 	if err != nil {
 		// Handle error
-		fmt.Println("failed")
+		fmt.Println(err)
 		return
 	}
 	fmt.Println(values.Encode())