[egs] Add set -o pipefail to all recipes (exit on Python errors) (ast…

…eroid-team#182)
someoneformulated · Jul 24, 2020 · e36c276 · e36c276
1 parent db5f71f
commit e36c276
Show file tree

Hide file tree

Showing 12 changed files with 48 additions and 13 deletions.
diff --git a/egs/avspeech/looking-to-listen/run.sh b/egs/avspeech/looking-to-listen/run.sh
@@ -1,6 +1,8 @@
 #!/bin/bash
 
+# Exit on error
 set -e
+set -o pipefail
 
 parse_boolean() {
 	# parses yaml boolean to flag.

diff --git a/egs/dns_challenge/baseline/run.sh b/egs/dns_challenge/baseline/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump DNS dataset.
 storage_dir=
@@ -92,4 +95,4 @@ if [[ $stage -le  5 ]]; then
 		--denoise_path $clone_dir/DNS-Challenge/datasets/test_set/real_recordings/ \
 		--use_gpu $eval_use_gpu \
 		--exp_dir $expdir
-fi
+fi
diff --git a/egs/fuss/baseline/run.sh b/egs/fuss/baseline/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory
 storage_dir=

diff --git a/egs/kinect-wsj/DeepClustering/run.sh b/egs/kinect-wsj/DeepClustering/run.sh
@@ -1,6 +1,9 @@
 #!/bin/bash
 
-set -e  # Exit on error
+# Exit on error
+set -e
+set -o pipefail
+
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.
 storage_dir=

diff --git a/egs/librimix/ConvTasNet/run.sh b/egs/librimix/ConvTasNet/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # If you haven't generated LibriMix start from stage 0
 # Main storage directory. You'll need disk space to store LibriSpeech, WHAM noises

diff --git a/egs/sms_wsj/CaCGMM/run.sh b/egs/sms_wsj/CaCGMM/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 
 storage_dir= # Main storage directory (Need disk space)
@@ -49,4 +52,4 @@ if [[ $stage -le  2 ]]; then
 		${python_path} -m pip install -e local/pb_bss[all]
 	fi
 	mpiexec -n $num_jobs ${python_path} start_evaluation.py --json_path $data_dir/sms_wsj.json
-fi
+fi
diff --git a/egs/wham/ConvTasNet/run.sh b/egs/wham/ConvTasNet/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.

diff --git a/egs/wham/DPRNN/run.sh b/egs/wham/DPRNN/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.

diff --git a/egs/wham/DynamicMixing/run.sh b/egs/wham/DynamicMixing/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.

diff --git a/egs/wham/TwoStep/run.sh b/egs/wham/TwoStep/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.

diff --git a/egs/whamr/TasNet/run.sh b/egs/whamr/TasNet/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.

diff --git a/egs/wsj0-mix/DeepClustering/run.sh b/egs/wsj0-mix/DeepClustering/run.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e  # Exit on error
+
+# Exit on error
+set -e
+set -o pipefail
 
 # Main storage directory. You'll need disk space to dump the WHAM mixtures and the wsj0 wav
 # files if you start from sphere files.