Check Python 3.10 in CI (#861)

No longer check and support Python 3.6 Also fix issue with wandb and protobuf by pinning versions.
skorch-dev · Jun 6, 2022 · bce1299 · bce1299
1 parent 8a0e379
commit bce1299
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -15,12 +15,16 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        python_version: ['3.6', '3.7', '3.8', '3.9']
+        python_version: ['3.7', '3.8', '3.9', '3.10']
         torch_version: ['1.8.1+cpu', '1.9.1+cpu', '1.10.2+cpu', '1.11.0+cpu']
         os: [ubuntu-latest]
         exclude:
-          - python_version: '3.6'
-            torch_version: '1.11.0+cpu'
+          - python_version: '3.10'
+            torch_version: '1.8.1+cpu'
+          - python_version: '3.10'
+            torch_version: '1.9.1+cpu'
+          - python_version: '3.10'
+            torch_version: '1.10.2+cpu'
 
     steps:
     - uses: actions/checkout@v2

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -10,6 +10,7 @@ numpydoc
 openpyxl
 pandas
 pillow
+protobuf>=3.12.0,<4.0dev
 pylint
 pytest>=3.4
 pytest-cov
@@ -18,4 +19,4 @@ sphinx
 sphinx_rtd_theme
 tensorboard>=1.14.0
 transformers
-wandb<0.10.29
+wandb>=0.12.17
diff --git a/setup.py b/setup.py
@@ -10,7 +10,7 @@
     install_requires = [l.strip() for l in f]
 
 
-python_requires = '>=3.6'
+python_requires = '>=3.7'
 
 tests_require = [
     'pytest',

diff --git a/skorch/tests/test_net.py b/skorch/tests/test_net.py
@@ -976,12 +976,7 @@ def test_save_params_with_history_file_path(
             self, net_cls, module_cls, net_fit, tmpdir, converter):
         # Test loading/saving with different kinds of path representations.
 
-        if converter is Path and sys.version < '3.6':
-            # `PosixPath` cannot be `open`ed in Python < 3.6
-            pytest.skip()
-
         net = net_cls(module_cls).initialize()
-
         history_before = net_fit.history
 
         p = tmpdir.mkdir('skorch').join('history.json')