New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive when on a final class protected method made into private #367

Open

cstamas opened this issue Nov 10, 2023 · 1 comment

Contributor

cstamas commented Nov 10, 2023

If there is a method w/ protected access on a final class, making that method into private triggers source incompatibility.

While the change lessen accessibility of the method from the package (call it "api"), is this really breaking compatibility with client code?

Contributor Author

cstamas commented Nov 10, 2023

Also, having protected method on final class does not make much sense, but it happened.

As I reported:

making it private is reported as breakage
making it package protected (removing any modifier) is reported as breakage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment