Skip to content

Commit

Permalink
[HOTFIX] Release v0.17.1 (patch Python 3.7) (voxel51#2100) (voxel51#2102
Browse files Browse the repository at this point in the history
)

* rm TypedDict

* bump

* needs all tests

* rm log

* adding release note

* fix desktop refresh

* bumps

* skip windows

Co-authored-by: brimoor <brimoor@umich.edu>

Co-authored-by: brimoor <brimoor@umich.edu>
  • Loading branch information
benjaminpkane and brimoor authored Sep 20, 2022
1 parent 8dbefcb commit c882fde
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 16 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ jobs:
exclude:
- os: windows-latest
python: 3.7
- os: windows-latest
python: 3.9
defaults:
run:
shell: bash
Expand Down Expand Up @@ -185,7 +187,7 @@ jobs:
- run: sh -c ${{ needs.test.result == 'success' }}

publish:
needs: [build]
needs: [build, all-tests]
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-20.04
steps:
Expand Down
2 changes: 1 addition & 1 deletion app/packages/app/src/Root/Datasets/Dataset.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const Dataset: Route<DatasetQuery> = ({ prepared }) => {

useEffect(() => {
update(({ set }) => {
if (router.state.refresh) {
if (router.state?.refresh) {
set(refresher, (cur) => cur + 1);
}
return {
Expand Down
1 change: 0 additions & 1 deletion app/packages/state/src/recoil/groups.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export const groupMediaTypes = selector<{ name: string; mediaType: string }[]>({
export const groupSlices = selector<string[]>({
key: "groupSlices",
get: ({ get }) => {
console.log(get(groupMediaTypes));
return get(groupMediaTypes)
.filter(
({ mediaType }) => !["point_cloud", "point-cloud"].includes(mediaType)
Expand Down
11 changes: 11 additions & 0 deletions docs/source/release-notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@ FiftyOne Release Notes

.. default-role:: code

.. _release-notes-v0.17.1:

FiftyOne 0.17.1
---------------
*Released September 20, 2022*

Core

- Removed `TypedDict` usage introduced in v0.17.0 that is not supported in
Python 3.7 `#2100 <https://github.com/voxel51/fiftyone/pull/2100>`_

.. _release-notes-v0.17.0:

FiftyOne 0.17.0
Expand Down
11 changes: 2 additions & 9 deletions fiftyone/server/tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
import fiftyone.server.view as fosv


class Label(t.TypedDict):
id: str
field: str
sample_id: str
frame_number: t.Optional[int]


def get_tag_view(
dataset: str,
stages: t.List,
Expand All @@ -30,8 +23,8 @@ def get_tag_view(
extended_stages: t.List = None,
sample_ids: t.Optional[t.List[str]] = None,
label_fields: t.List[str] = None,
labels: t.Optional[t.List[Label]] = None,
hidden_labels: t.Optional[t.List[Label]] = None,
labels: t.Optional[t.List[t.Dict]] = None,
hidden_labels: t.Optional[t.List[t.Dict]] = None,
sample_filter: SampleFilter = None,
target_labels: bool = False,
modal: bool = False,
Expand Down
2 changes: 1 addition & 1 deletion package/desktop/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import shutil


VERSION = "0.23.0"
VERSION = "0.23.1"


def get_version():
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from setuptools import setup, find_packages


VERSION = "0.17.0"
VERSION = "0.17.1"


def get_version():
Expand Down Expand Up @@ -66,7 +66,7 @@ def get_version():
"xmltodict",
"universal-analytics-python3>=1.0.1,<2",
# internal packages
"fiftyone-brain>=0.9,<0.10",
"fiftyone-brain>=0.9.1,<0.10",
"fiftyone-db>=0.3,<0.4",
"voxel51-eta>=0.8.1,<0.9",
]
Expand Down Expand Up @@ -105,7 +105,7 @@ def get_install_requirements(install_requires, choose_install_requires):
return install_requires


EXTRAS_REQUIREMENTS = {"desktop": ["fiftyone-desktop>=0.23,<0.24"]}
EXTRAS_REQUIREMENTS = {"desktop": ["fiftyone-desktop>=0.23.1,<0.24"]}


with open("README.md", "r") as fh:
Expand Down

0 comments on commit c882fde

Please sign in to comment.