Skip to content

Commit

Permalink
[HOTFIX] Backward Compatible App (voxel51#2103)
Browse files Browse the repository at this point in the history
* [HOTFIX] Release v0.17.1 (patch Python 3.7) (voxel51#2100)

* rm TypedDict

* bump

* needs all tests

* rm log

* adding release note

* fix desktop refresh

* bumps

* skip windows

Co-authored-by: brimoor <brimoor@umich.edu>

* safe app config usage

* bumps

* release notes

* being more specific

Co-authored-by: brimoor <brimoor@umich.edu>
  • Loading branch information
benjaminpkane and brimoor authored Sep 21, 2022
1 parent c882fde commit 7843c4a
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 7 deletions.
6 changes: 3 additions & 3 deletions app/packages/state/src/hooks/useStateUpdate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,11 @@ const useStateUpdate = () => {
reset(similarityParameters);
set(
selectedMediaField(false),
dataset.appConfig.gridMediaField || "filepath"
dataset?.appConfig?.gridMediaField || "filepath"
);
reset(
set(
selectedMediaField(true),
dataset.appConfig.modalMediaField || "filepath"
dataset?.appConfig?.modalMediaField || "filepath"
);
reset(extendedSelection);
reset(filters);
Expand Down
11 changes: 11 additions & 0 deletions docs/source/release-notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@ FiftyOne Release Notes

.. default-role:: code

.. _release-notes-v0.17.2:

FiftyOne 0.17.2
---------------
*Released September 20, 2022*

App

- Fixed a backward compatability bug when connecting to older database verions
`#2103 <https://github.com/voxel51/fiftyone/pull/2103>`_

.. _release-notes-v0.17.1:

FiftyOne 0.17.1
Expand Down
8 changes: 7 additions & 1 deletion fiftyone/server/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,14 @@ class FFmpegNotFoundException(RuntimeError):
def _create_media_urls(
collection: SampleCollection, sample: t.Dict, cache: t.Dict
) -> t.Dict[str, str]:
media_fields = (
collection.app_config.media_fields
if collection.app_config
else ["filepath"]
)
media_urls = []
for field in collection.app_config.media_fields:

for field in media_fields:
path = sample.get(field, None)
if path not in cache:
cache[path] = path
Expand Down
2 changes: 1 addition & 1 deletion package/desktop/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import shutil


VERSION = "0.23.1"
VERSION = "0.23.2"


def get_version():
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from setuptools import setup, find_packages


VERSION = "0.17.1"
VERSION = "0.17.2"


def get_version():
Expand Down Expand Up @@ -105,7 +105,7 @@ def get_install_requirements(install_requires, choose_install_requires):
return install_requires


EXTRAS_REQUIREMENTS = {"desktop": ["fiftyone-desktop>=0.23.1,<0.24"]}
EXTRAS_REQUIREMENTS = {"desktop": ["fiftyone-desktop>=0.23.2,<0.24"]}


with open("README.md", "r") as fh:
Expand Down

0 comments on commit 7843c4a

Please sign in to comment.