Skip to content

Commit

Permalink
Disable slow websocket performance tests by default.
Browse files Browse the repository at this point in the history
Add pypy to the mix for when we do run the perf tests.  Depending on
the benchmark pypy is ~twice as fast as cpython 2.7
  • Loading branch information
bdarnell committed Jan 22, 2012
1 parent bc28966 commit 5a18d50
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion maint/test/websocket/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
define('cases', type=str, multiple=True,
default=["*"])
define('exclude', type=str, multiple=True,
default=[])
default=["9.*"])

if __name__ == '__main__':
parse_command_line()
Expand Down
10 changes: 7 additions & 3 deletions maint/test/websocket/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
# python2 and python3. Output goes in ./reports/servers/index.html.
#
# The --cases and --exclude arguments can be used to run only part of
# the suite. --exclude="9.*" is useful to skip the relatively slow
# performance tests.
# the suite. The default is --exclude="9.*" to skip the relatively slow
# performance tests; pass --exclude="" to override and include them.

set -e

Expand All @@ -21,13 +21,17 @@ PY27_SERVER_PID=$!
.tox/py32/bin/python server.py --port=9003 &
PY32_SERVER_PID=$!

.tox/pypy/bin/python server.py --port=9004 &
PYPY_SERVER_PID=$!

sleep 1

.tox/py27/bin/python ./client.py --servers=Tornado/py25=ws://localhost:9001,Tornado/py27=ws://localhost:9002,Tornado/py32=ws://localhost:9003 "$@"
.tox/py27/bin/python ./client.py --servers=Tornado/py25=ws://localhost:9001,Tornado/py27=ws://localhost:9002,Tornado/py32=ws://localhost:9003,Tornado/pypy=ws://localhost:9004 "$@" || true

kill $PY25_SERVER_PID
kill $PY27_SERVER_PID
kill $PY32_SERVER_PID
kill $PYPY_SERVER_PID
wait

echo "Tests complete. Output is in ./reports/servers/index.html"
2 changes: 1 addition & 1 deletion maint/test/websocket/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ def on_message(self, message):
app = Application([
('/', EchoHandler),
])
app.listen(options.port, address='localhost')
app.listen(options.port, address='127.0.0.1')
IOLoop.instance().start()
2 changes: 1 addition & 1 deletion maint/test/websocket/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# to install autobahn and deal with 2to3 for the python3 version.
# See run.sh for the real test runner.
[tox]
envlist = py27, py32, py25
envlist = py27, py32, py25, pypy
setupdir=../../..

[testenv]
Expand Down

0 comments on commit 5a18d50

Please sign in to comment.