fixes the array index unset issue (#22)

sdgluck · Mar 30, 2017 · d47bda0 · d47bda0
1 parent 990e5c2
commit d47bda0
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 9 deletions.
diff --git a/index.js b/index.js
@@ -30,6 +30,9 @@ function mewt(target) {
       return mewt(newObj)
     },
     $unset (prop) {
+      if (isA && Number.isInteger(prop) && prop >= 0) {
+        return mewt(target.slice(0, prop).concat(target.slice(prop + 1)))
+      }
       const newObj = clone(target)
       delete newObj[prop]
       return mewt(newObj)

diff --git a/lib/index.js b/lib/index.js
diff --git a/test.js b/test.js
@@ -22,24 +22,24 @@ describe('mewt', () => {
     it('should throw when null given', () => {
       expect(() => mewt(null)).toThrowError(/accepts array or object/)
     })
-    
+
     it('should throw when string given', () => {
       expect(() => mewt('foo')).toThrowError(/accepts array or object/)
     })
-    
+
     it('should throw when number given', () => {
       expect(() => mewt(123)).toThrowError(/accepts array or object/)
     })
-    
+
     it('should throw when boolean given', () => {
       expect(() => mewt(true)).toThrowError(/accepts array or object/)
       expect(() => mewt(false)).toThrowError(/accepts array or object/)
     })
-    
+
     it('should throw when function given', () => {
       expect(() => mewt(() => { })).toThrowError(/accepts array or object/)
     })
-    
+
     it('should throw when Symbol given', () => {
       expect(() => mewt(Symbol('foo'))).toThrowError(/accepts array or object/)
     })
@@ -76,14 +76,23 @@ describe('mewt', () => {
       assertMewt(n)
     })
 
-    xit('should properly $unset at index', () => {
+    it('should properly $unset at index', () => {
       const a = mewt([''])
       const n = a.$unset(0)
       expect(n).toEqual([])
       expect(a).not.toBe(n)
       assertMewt(n)
     })
 
+    it('should properly $unset negative indexes and string keys', () => {
+      const a = mewt([1, 2, 3])
+      const n = a.$set('foo', 'bar')
+        .$set(-1, 42)
+        .$unset(-1)
+        .$unset('foo')
+      expect(n).toEqual([1, 2, 3])
+    })
+
     it('should copyWithin without mutation', () => {
       const a = mewt([1, 2])
       const n = a.copyWithin(0, 2)
@@ -224,9 +233,9 @@ describe('mewt', () => {
     it('should throw on setPrototypeOf', () => {
       const o = mewt({})
       expect(() => {
-        Object.setPrototypeOf(o, {bar: 'baz'})
+        Object.setPrototypeOf(o, { bar: 'baz' })
       }).toThrowError(/immutable/)
-    })    
+    })
 
     it('should have $set & $unset', () => {
       const o = mewt({})
@@ -253,5 +262,11 @@ describe('mewt', () => {
       expect(n.album).toBeUndefined()
       expect(o).not.toBe(n)
     })
+
+    it('should properly $unset numeric indexes', () => {
+      const o = mewt({ foo: 'bar', 0: 'foo', 1: 'bar' })
+      expect(o.$unset(0)).toEqual({ foo: 'bar', 1: 'bar' })
+      expect(o.$unset(1)).toEqual({ foo: 'bar', 0: 'foo' })
+    })
   })
 })